fix: make sure to propagate the response when throttling is enabled #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I690c522aebea03a966155d930bff26042d1bb1f1
product-auto-label
bot
added
size: s
rameshdharan
approved these changes
Sep 12, 2023
igorbernstein2
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
🤖 I have created a release *beep* *boop* --- ## [2.27.1](https://togithub.com/googleapis/java-bigtable/compare/v2.27.0...v2.27.1) (2023-09-12) ### Bug Fixes * Aggregate batching throttling latency per attempt and reset it between ([#1905](https://togithub.com/googleapis/java-bigtable/issues/1905)) ([e6cc5f6](https://togithub.com/googleapis/java-bigtable/commit/e6cc5f615630d15b717df1056ceed98f21f2297b)) * Make sure to propagate the response when throttling is enabled ([#1908](https://togithub.com/googleapis/java-bigtable/issues/1908)) ([f743187](https://togithub.com/googleapis/java-bigtable/commit/f7431871ba4ea64351fc5710089f8308e91d7978)) ### Dependencies * Update the Java code generator (gapic-generator-java) to 2.25.0 ([#1902](https://togithub.com/googleapis/java-bigtable/issues/1902)) ([f4fe6a0](https://togithub.com/googleapis/java-bigtable/commit/f4fe6a054194f68da1d7a548dec7a1cec68c1a2c)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
kolea2
pushed a commit
to kolea2/java-bigtable
that referenced
this pull request
Sep 15, 2023
…oogleapis#1908) Change-Id: I690c522aebea03a966155d930bff26042d1bb1f1 Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
kolea2
added a commit
that referenced
this pull request
Sep 15, 2023
…1908) (#1922) Change-Id: I690c522aebea03a966155d930bff26042d1bb1f1 Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md). Co-authored-by: Igor Bernstein <igorbernstein@google.com>
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
🤖 I have created a release *beep* *boop* --- ## [2.25.2](https://togithub.com/googleapis/java-bigtable/compare/v2.25.0...v2.25.2) (2023-09-18) ### Bug Fixes * Check that all bulk mutation entries are accounted for ([#1907](https://togithub.com/googleapis/java-bigtable/issues/1907)) ([#1923](https://togithub.com/googleapis/java-bigtable/issues/1923)) ([e4db745](https://togithub.com/googleapis/java-bigtable/commit/e4db74534690eb090347c00047eecbd45f5a22b7)) * Make sure to propagate the response when throttling is enabled ([#1908](https://togithub.com/googleapis/java-bigtable/issues/1908)) ([#1922](https://togithub.com/googleapis/java-bigtable/issues/1922)) ([7ec5dd5](https://togithub.com/googleapis/java-bigtable/commit/7ec5dd5bc9499b01f5e330c28c9c5ee8cfadad68)) ### Miscellaneous Chores * Update release tag to 2.25.2 ([#1926](https://togithub.com/googleapis/java-bigtable/issues/1926)) ([9d5868b](https://togithub.com/googleapis/java-bigtable/commit/9d5868b2350f2b24b5988ebe3adb2e77e36c8a5a)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
gcf-owl-bot bot
added a commit
that referenced
this pull request
Dec 5, 2023
…p/templates/java_library/.kokoro (#1908) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65
kolea2
pushed a commit
that referenced
this pull request
Dec 5, 2023
…p/templates/java_library/.kokoro (#1908) (#2023) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I690c522aebea03a966155d930bff26042d1bb1f1
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.