New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update linked packages in package-lock.json #1844
base: main
Are you sure you want to change the base?
feat: Update linked packages in package-lock.json #1844
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Updated CLA |
This should be the right direction, but I'm still struggling with the test. Any help would be greatly appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests to ensure we don't regress.
I'm still struggling with the test
To test, you can run:
npm i
npm t
If you don't have node available, you can run this in a stock GitHub Codespace (IIRC, node 19 is installed which should suffice).
As for the contents of the test, you can probably:
- augment an existing node-workspace test to ensure that it has an update for the package-lock.json file
- add a test to the package-lock-json updater to ensure it updates multiple versions
Sorry, I have currently no time to get back to this, could anyone continue on that one? |
Hi, I'm making a start for #1842 as this is very important for me.
I'm not fully into the code and this is just the starting point in my opinion.
Would love if someone could assist on this one!
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Addresses #1842 🦕