feat: Update linked packages in package-lock.json

src/plugins/node-workspace.ts

@@ -28,14 +28,15 @@ import {BranchName} from '../util/branch-name';
 import {jsonStringify} from '../util/json-stringify';
 import {Changelog} from '../updaters/changelog';
 import {
-  WorkspacePlugin,
+  addPath,
+  appendDependenciesSectionToChangelog,
   DependencyGraph,
   DependencyNode,
+  WorkspacePlugin,
   WorkspacePluginOptions,
-  appendDependenciesSectionToChangelog,
-  addPath,
 } from './workspace';
 import {PatchVersionUpdate} from '../versioning-strategy';
+import {PackageLockJson} from '../updaters/node/package-lock-json';
 
 class Package extends LernaPackage {
   constructor(
@@ -65,6 +66,7 @@ interface NodeWorkspaceOptions extends WorkspacePluginOptions {
 export class NodeWorkspace extends WorkspacePlugin<Package> {
   private alwaysLinkLocal: boolean;
   private packageGraph?: PackageGraph;
+
   constructor(
     github: GitHub,
     targetBranch: string,
@@ -74,6 +76,7 @@ export class NodeWorkspace extends WorkspacePlugin<Package> {
     super(github, targetBranch, repositoryConfig, options);
     this.alwaysLinkLocal = options.alwaysLinkLocal === false ? false : true;
   }
+
   protected async buildAllPackages(
     candidates: CandidateReleasePullRequest[]
   ): Promise<{
@@ -201,6 +204,13 @@ export class NodeWorkspace extends WorkspacePlugin<Package> {
                 this.logger
               );
           }
+        } else if (
+          update.path === addPath(existingCandidate.path, 'package-lock.json')
+        ) {
+          update.updater = new PackageLockJson({
+            version: Version.parse(updatedPackage.version),
+            versionsMap: updatedVersions,
+          });
         }
         return update;
       });
@@ -228,6 +238,7 @@ export class NodeWorkspace extends WorkspacePlugin<Package> {
     }
     return existingCandidate;
   }
+
   protected newCandidate(
     pkg: Package,
     updatedVersions: VersionsMap
@@ -300,6 +311,14 @@ export class NodeWorkspace extends WorkspacePlugin<Package> {
             ),
           }),
         },
+        {
+          path: addPath(updatedPackage.location, 'package-lock.json'),
+          createIfMissing: false,
+          updater: new PackageLockJson({
+            version: version,
+            versionsMap: updatedVersions,
+          }),
+        },
       ],
       labels: [],
       headRefName: BranchName.ofTargetBranch(this.targetBranch).toString(),
@@ -320,6 +339,18 @@ export class NodeWorkspace extends WorkspacePlugin<Package> {
     _updatedVersions: VersionsMap
   ): CandidateReleasePullRequest[] {
     // NOP for node workspaces
+
+    // not sure about this
+    // candidates.forEach(c => {
+    //   c.pullRequest.updates.push({
+    //     path: 'package-lock.json',
+    //     updater: new PackageLockJson({
+    //       version: c.pullRequest.version!,
+    //       versionsMap: _updatedVersions,
+    //     }),
+    //     createIfMissing: false,
+    //   });
+    // });
     return candidates;
   }
 

src/strategies/node.ts

@@ -31,6 +31,7 @@ export class Node extends BaseStrategy {
   ): Promise<Update[]> {
     const updates: Update[] = [];
     const version = options.newVersion;
+    const versionsMap = options.versionsMap;
     const packageName = (await this.getPackageName()) ?? '';
     const lockFiles = ['package-lock.json', 'npm-shrinkwrap.json'];
     lockFiles.forEach(lockFile => {
@@ -39,6 +40,7 @@ export class Node extends BaseStrategy {
         createIfMissing: false,
         updater: new PackageLockJson({
           version,
+          versionsMap,
         }),
       });
     });

src/updaters/node/package-lock-json.ts

@@ -19,7 +19,7 @@ import {DefaultUpdater} from '../default';
 type LockFileV2 = {
   version: string;
   lockfileVersion?: number;
-  packages: Record<string, {version: string}>;
+  packages: Record<string, {version: string; name: string}>;
 };
 
 /**
@@ -33,6 +33,19 @@ export class PackageLockJson extends DefaultUpdater {
     parsed.version = this.version.toString();
     if (parsed.lockfileVersion === 2) {
       parsed.packages[''].version = this.version.toString();
+      this.versionsMap?.forEach((version, linkedPackage) => {
+        logger.info(
+          `updating from ${
+            parsed.packages[linkedPackage].version
+          } to ${version.toString()}`
+        );
+        const packageKey = Object.keys(parsed.packages).find(
+          p => parsed.packages[p].name === linkedPackage
+        );
+        if (!packageKey)
+          throw Error(`${packageKey} not found in ${parsed.packages}`);
+        parsed.packages[packageKey].version = version.toString();
+      });
     }
     return jsonStringify(parsed, content);
   }