feat: Gitea client add create file function

[6543]

implement for brew and scoop support for Gitea-hosted repos

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/1pzsx4glh
✅ Preview: https://goreleaser-git-fork-6543-forks-giteaclientaddcreatefile.goreleaser.now.sh

[codecov]

Codecov Report

Merging #1547 (2b9a42c) into master (9a19dee) will decrease coverage by 0.03%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
- Coverage   81.76%   81.73%   -0.04%     
==========================================
  Files          73       73              
  Lines        3834     3866      +32     
==========================================
+ Hits         3135     3160      +25     
- Misses        574      580       +6     
- Partials      125      126       +1     

Impacted Files	Coverage Δ
pkg/config/config.go	93.75% <ø> (ø)
internal/client/gitea.go	87.50% <75.00%> (-2.86%)	⬇️
internal/pipe/defaults/defaults.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a19dee...2b9a42c. Read the comment docs.

[6543]

@caarlos0 I removed dummy test and add a real one now CI works

only problem is codecov now thinks this pull is bad :/

[radeksimko]

Thanks for the PR, this looks like a good start. However there's some more work that would need to be done in order to actually support gitea in Homebrew and Scoop.

Specifically the brews config section currently only supports GitHub and GitLab:

goreleaser/pkg/config/config.go

Lines 81 to 82 in c31cc85

	GitHub Repo `yaml:",omitempty"`
	GitLab Repo `yaml:",omitempty"`

I think the best way forward would be refactoring the Homebrew packaging/publishing so that it is more aligned with Scoop, which is more git-host agnostic:

goreleaser/pkg/config/config.go

Line 105 in c31cc85

Bucket Repo `yaml:",omitempty"`

That may require planning some deprecations though.

@caarlos0 What are your thoughts on the deprecation?

[6543]

@radeksimko avter you have looked at the commits, If I should squash them just tell

[caarlos0]

@caarlos0 What are your thoughts on the deprecation?

I think it should be fine, yes...

[6543]

@radeksimko @caarlos0 current state?

[caarlos0]

as @radeksimko mentioned, this pr alone does nothing... need the changes on brew/scoop pipe as well...

[6543]

hmm ok feel free to cherry-pick this :)

[mavogel]

Update:

• I got it fixed by creating an empty Formula folder in the homebrew-tap repository.
• then it was possible to install the binary via

brew tap mavogel/gitea-tools ssh://git@localhost:222/mavogel/homebrew-tap.git
brew install mavogel/gitea-tools/release-testing

So happy to have it successfully tested in the wild for brews 🎉
Should we open an issue anyway for the SDK function when trying to create a file in a non-existing path, should return another error than the one json: cannot unmarshal?

[6543]

@mavogel pleace do :) - I'm happy to follow up on that specific issue on a new created issue in the sdk repository :)

[6543]

@radeksimko added
@caarlos0 think it is ready & tested now :)

[6543]

@caarlos0 do you squash-merge or should i swash it?

[6543]

@caarlos0 thanks for the advice - done

[mavogel]

@6543 : there you go: https://gitea.com/gitea/go-sdk/issues/459

@caarlos0 : for the testing setup there was a lot of manual work to do until I discovered this recent setup of gitea. IMHO it would make sense to add this and some additional steps (like homebrew-tap repo creation) to the docs. For gitlab as well, so Acc tests can be set-up quickly. What do you think? I could contribute this

[caarlos0]

@caarlos0 : for the testing setup there was a lot of manual work to do until I discovered this recent setup of gitea. IMHO it would make sense to add this and some additional steps (like homebrew-tap repo creation) to the docs. For gitlab as well, so Acc tests can be set-up quickly. What do you think? I could contribute this

you mean as documentation?

I think it makes sense to put somewhere, or at least link to it somewhere, yes 🤔

[6543]

something missing?

[caarlos0]

Thanks everyone

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.