Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Starting on resource groups, subscriptions POST endpoint, and refactoring/reorganizing #12

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

[WIP] Starting on resource groups, subscriptions POST endpoint, and refactoring/reorganizing #12

wants to merge 17 commits into from

Conversation

jessemillar
Copy link
Collaborator

I think I started this with the intention of creating resource groups and instead made a bunch of changes to HTTP endpoints and made a POST endpoint for creating a subscription. I don't think that new sub gets saved to our "grab bag" currently though. Will have to discuss how we're doing that since I don't remember.

@goshlanguage goshlanguage added this to In progress in Alpha Sep 2, 2020
goshlanguage
goshlanguage reviewed Sep 2, 2020
View reviewed changes
go.sum Show resolved Hide resolved
@jessemillar jessemillar changed the title Uh... [WIP] Starting on resource groups, subscriptions POST endpoint, and refactoring/reorganizing Sep 22, 2020
@jessemillar jessemillar self-assigned this Sep 23, 2020
@jessemillar
Copy link
Collaborator Author

jessemillar commented Sep 23, 2020 •
edited by goshlanguage

Things left to do:

  • Add README to /services/resourceGroups (similar to the one in /services/subscriptions
  • Enable some form of rudimentary grab bag to store created resource groups
  • Finish out current /tests/resourceGroups_test.go (needs actual assertions and the grab bag mentioned above)
  • Flesh out /tests/resourceGroups_test.go with GET and LIST endpoinds/handler usage to make sure resource groups is fully working

@jessemillar
Copy link
Collaborator Author

We're breaking this PR into smaller PRs as part of an effort to rearchitect the project and follow more of an agile cadence.

@jessemillar jessemillar mentioned this pull request Oct 8, 2020
Open
@jessemillar jessemillar marked this pull request as draft October 28, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goshlanguage goshlanguage goshlanguage left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jessemillar jessemillar

Labels
None yet
Projects
Alpha
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jessemillar @goshlanguage