TypeScript: import formatDate and parseDate from react-day-picker/moment

[singingwolfboy]

This allows TypeScript to understand the following import:

import MomentLocaleUtils, {
  formatDate,
  parseDate,
} from 'react-day-picker/moment';

as specified in the documentation.

[codecov-io]

Codecov Report

Merging #895 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #895   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         659    659           
  Branches      146    146           
=====================================
  Hits          659    659

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421af9f...83234f0. Read the comment docs.

[fivetwelve]

I wonder if this has something to do with the following issue I am having (using v7.3.0)?

When trying to call formatDate(selectedDay, 'LL', myLocale) where I've tried equating myLocale to 'en' and 'en-us', I get a deprecation warning. However, if I call formatDate(selectedDay, 'LL', 'en'), there is no warning. Not ideal since I need to support multiple locales and prefer not to (and shouldn't have to) hardcode the locale.

Warning is:
Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.

[fivetwelve]

Not sure I understand why this works since the function funnels over to moment functions but this seemed to work for me and avoided displaying any warnings:

formatDate(new Date(yourDate), 'LL', yourLocale).

It didn't matter that my date string was moment-compatible. I tried the date returned by react-day-picker as well as a string that moment could parse such as '2019 July'. In any case, I hope my workaround is forward-compatible.

[singingwolfboy]

@fivetwelve this change only affects the TypeScript compiler. It has no effect on how the JavaScript in this project runs. If you are getting a deprecation warning, that is from JavaScript, not from the TypeScript compiler.

[qbolt]

I could really use this! Hope it gets merged soon.

[MartinNuc]

any news regarding this PR?

[gpbl]

Is this fixed via #899?

[gpbl]

Closing as seems fixed. Please reopen if needed, thanks!

[davidpmccormick]

I'm seeing this issue with version 7.4.10