[GPII-4057]: Lock gem versions with bundler #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM I guess this should go to upstream as well. FYI in case it comes up: I've had trouble with these google gems in the past: https://github.com/gpii-ops/gpii-infra/blob/master/shared/rakefiles/tests/Gemfile#L11 |
Thanks for doing this @natarajaya, LGTM. I think you'll need a new version, Note: I noticed this adds another 30M to our (already huge ;() exekube image:
@mrtyler given upstream does not have Ruby at all... how? |
Oops, I forgot that ruby is only for us. Ignore the request to upstream. |
Thanks for reviews!
@mrtyler Nice catch! Since we bundle gems in exekube now, I had to add rspec into separate group and remove gemfiles from gpii-infra. |
This is a follow-up on gpii-ops/gpii-infra#472.
This also bumps Stackdriver gems to latest versions.