Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constant analysis for package-info and module-info #17504

Closed
wants to merge 1 commit into from

Conversation

asodja
Copy link
Member

@asodja asodja commented Jun 21, 2021

Signed-off-by: Anze Sodja anze.36@gmail.com

Fixes #17488

Context

As written in #17488 problem was how package-info was handled on JDK8. This fixes it, additionally it adds proper integration tests.

Additionally to package-info case it fixes also module-info case that was missing.

Tested also with Micronaut-kafka with JDK8, 11 and 16.

Contributor Checklist

  • Review Contribution Guidelines
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • Provide unit tests (under <subproject>/src/test) to verify logic
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • Ensure that tests pass sanity check: ./gradlew sanityCheck
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation
  • Recognize contributor in release notes

Signed-off-by: Anze Sodja <anze.36@gmail.com>
@wolfs wolfs self-assigned this Jun 22, 2021
@wolfs wolfs added this to the 7.1.1 milestone Jun 22, 2021
@wolfs
Copy link
Member

wolfs commented Jun 22, 2021

@bot-gradle test QFL

@bot-gradle
Copy link
Collaborator

OK, I've already triggered QuickFeedbackLinux build for you.

Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, that looks great! I left one question.

@wolfs
Copy link
Member

wolfs commented Jun 24, 2021

Thank you again @asodja! I rebased this PR on release in #17518, since we are going to release a 7.1.1 version with this fix. Then I merged release into master, so the fix is now also there.

I am going to close this PR now, given that I integrated it manually.

@wolfs wolfs closed this Jun 24, 2021
@ov7a ov7a removed this from the 7.1.1 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many Micronaut builds failing with NPE with Gradle 7.1 & JDK 8
4 participants