Fix constant analysis for package-info and module-info #17518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anze Sodja <anze.36@gmail.com>
wolfs
force-pushed
the
wolfs/java/fix-constant-analysis
branch
from
ee86f02
to
6957c9f
Compare
|
@bot-gradle cancel |
|
OK, I've already cancelled the pre-tested commit build. |
|
@bot-gradle test and merge |
|
OK, I've already triggered a build for you. |
This was referenced Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17488
Context
As written in #17488 problem was how package-info was handled on JDK8. This fixes it, additionally it adds proper integration tests.
Additionally to package-info case it fixes also module-info case that was missing.
Tested also with Micronaut-kafka with JDK8, 11 and 16.
This is #17504 rebased on the release branch.