Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Fix incremental compilation with modules" to 7.6.1 #23913

Merged
merged 2 commits into from Feb 17, 2023
Merged

Backport "Fix incremental compilation with modules" to 7.6.1 #23913

merged 2 commits into from Feb 17, 2023

Conversation

asodja
Copy link
Member

@asodja asodja commented Feb 15, 2023

Backport from #23119 to 7.6.1.

Also backport from #23251 to 7.6.1

Fixes #23224

@bot-gradle bot-gradle added this to the 7.6.1 milestone Feb 15, 2023
@asodja asodja modified the milestones: 7.6.1, 7.x backport Feb 15, 2023
@asodja asodja marked this pull request as draft February 15, 2023 17:23
@asodja asodja modified the milestones: 7.x backport, 7.6.1 Feb 16, 2023
@asodja asodja force-pushed the asodja/7.x-backport-modules-fix branch from 995d897 to 9c171fc Compare February 16, 2023 14:32
@asodja asodja force-pushed the asodja/7.x-backport-modules-fix branch from 9c171fc to 51db260 Compare February 16, 2023 14:34
@asodja
Copy link
Member Author

asodja commented Feb 16, 2023

@bot-gradle test this

@gradle gradle deleted a comment from asodja Feb 16, 2023
@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you:

@asodja asodja changed the title Fix incremental compilation with modules Backport "Fix incremental compilation with modules" to 7.6.1 Feb 17, 2023
@asodja asodja requested a review from lptr February 17, 2023 09:04
@asodja asodja marked this pull request as ready for review February 17, 2023 09:04
lptr
lptr approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@lptr lptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@asodja
Copy link
Member Author

asodja commented Feb 17, 2023

@bot-gradle test and merge

@gradle gradle deleted a comment from asodja Feb 17, 2023
@bot-gradle
Copy link
Collaborator

I've triggered a build for you.

@bot-gradle bot-gradle merged commit 952184f into release7x Feb 17, 2023
@bot-gradle bot-gradle deleted the asodja/7.x-backport-modules-fix branch February 17, 2023 12:31
@asodja asodja mentioned this pull request Feb 17, 2023
Closed
@lptr lptr mentioned this pull request Feb 20, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lptr lptr lptr approved these changes

Assignees

@asodja asodja

Labels
None yet
Projects
None yet
Milestone
7.6.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asodja @bot-gradle @lptr