Sg/89/merge/april19 #28888
Draft
Sg/89/merge/april19 #28888
+2,659
−1,303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By including the `JavaObjectSerializationCodec` in the set of `IsolatedAction` codecs.
- Improve `environment` documentation - Choose better names - Extract `Map<K, V>.invert(): HashMap<V, K>` extension
In the first release we'll be explicitly forbidding: - `ValueSourceProvider` for we need more time to design how to maximize cache hits in their presence; - `BuildServiceProvider` for we want to encourage actions to avoid shared mutable state of any kind; - `FileCollection` for it's currently not clear how dependency resolution should work for isolated actions; These limitations might be lifted in a subsequent release.
- Format for symmetry - Polish docs - Add todo
Via `ProxyCodec`.
And their equivalent property types. Plus build-scoped service instances.
And move tests to `:core` so they are executed with all Gradle test executors.
Instead of `IsolatedAction` which is more of an implementation detail.
This version simply throws the first serialization error that occurs during isolation. This will change soon to use the Problems API.
And more explicitly connecting it to the `IsolatedAction` concept.
- Reduce visibility of `SerializedIsolatedActionGraph` - Better name for `toLookup` - Replace `if null` by `computeIfAbsent`
This makes continuous build work with serveDocs
Co-authored-by: Tom Tresansky <ttresansky@gradle.com> Signed-off-by: Sterling Greene <big-guy@users.noreply.github.com>
This makes the implementation of a custom dependencies block consistently shown in Java.
Which allows identities to be shared across different actions.
When there are two JDKs with same major version installed, the test might behave flaky because it starts the test with ``` export JAVA_HOME=/jdkPath1 gradle run -Porg.gradle.java.installations.paths=/jdkPath2 ``` Now if the target JDK path matches current JDK version, we'll just use current JDK path instead of searching another Java homes.
Latest Develocity uses the new GradleLifecycle API which relies on Configuration Cache serialization. Configuration Cache serialization relies on reflection to serialize `SerializedLambda`.
Co-authored-by: Laura Kassovic <lkassovic@gradle.com> Signed-off-by: Sterling Greene <big-guy@users.noreply.github.com>
* origin/release: (44 commits) Fix deadlink in new docs Apply suggestions from code review Add required `--add-opens` on perf tests using Develocity Fix broken javadoc Fix flaky JavaCrossCompilationIntegrationTest Add some minimal documentation about Daemon JVM discovery/criteria Change name of toolchain-version to jvm-version for UpdateDaemonJvm Extract JavaInstallationRegistry interface from implementation Make the other installation suppliers work for daemon toolchain detection too Move `IsolatedProject` to `org.gradle.api.project` package Introduce `GradleLifecycle#afterProject(IsolatedAction<Project>)` Reduce duplication by using a common directory for snippet example Prove `GradleLifecycle` actions are isolated per project Add convenience overloads to `AbstractIntegrationSpec#(groovy|java)File` Add note about the name of the dependencies block Make the example plugin entirely Java Add link to new documentation from Dependencies javadoc Move wiring logic to Java too Accept suggestion for rewording Fix plugin validation error ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective.<subproject>/src/test) to verify logic../gradlew sanityCheck../gradlew <changed-subproject>:quickTest.Reviewing cheatsheet
Before merging the PR, comments starting with