Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sg/89/merge/april19 #28888

Draft
wants to merge 54 commits into
base: master
Choose a base branch
from
Draft

Sg/89/merge/april19 #28888

wants to merge 54 commits into from

Commits on Apr 17, 2024

  1. Configuration menu
    Copy the full SHA
    9877d66 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0e41236 View commit details
    Browse the repository at this point in the history
  3. Let IsolatedAction carry Java lambdas

    By including the `JavaObjectSerializationCodec` in the set of `IsolatedAction`
    codecs.
    bamboo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ab0bd9a View commit details
    Browse the repository at this point in the history
  4. Polish IsolatedActionSerializer.kt

    - Improve `environment` documentation
    - Choose better names
    - Extract `Map<K, V>.invert(): HashMap<V, K>` extension
    bamboo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    02606b0 View commit details
    Browse the repository at this point in the history
  5. Let IsolatedAction carry Property, Provider and service references

    In the first release we'll be explicitly forbidding:
    - `ValueSourceProvider` for we need more time to design how to maximize cache hits in
       their presence;
    - `BuildServiceProvider` for we want to encourage actions to avoid shared
       mutable state of any kind;
    - `FileCollection` for it's currently not clear how dependency resolution should
       work for isolated actions;
    
    These limitations might be lifted in a subsequent release.
    bamboo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5bd07fe View commit details
    Browse the repository at this point in the history
  6. Polish IsolateActionCodecsFactory and family

    - Format for symmetry
    - Polish docs
    - Add todo
    bamboo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    68db876 View commit details
    Browse the repository at this point in the history
  7. Let IsolatedAction carry Proxy instances

    Via `ProxyCodec`.
    bamboo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    fe94b56 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4898908 View commit details
    Browse the repository at this point in the history
  9. Let IsolatedAction carry Directory and RegularFile instances

    And their equivalent property types. Plus build-scoped service instances.
    bamboo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    efc97ee View commit details
    Browse the repository at this point in the history
  10. Introduce integration tests for all IsolatedAction supported types

    And move tests to `:core` so they are executed with all Gradle test executors.
    bamboo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    901fcc1 View commit details
    Browse the repository at this point in the history
  11. Rename integration tests to be about GradleLifecycle

    Instead of `IsolatedAction` which is more of an implementation detail.
    bamboo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    36cbdbf View commit details
    Browse the repository at this point in the history
  12. Fail the build when a GradleLifecycle action cant be isolated

    This version simply throws the first serialization error that occurs during
    isolation.
    
    This will change soon to use the Problems API.
    bamboo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ac81d3d View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    cbc5e66 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    468197d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    1f979b0 View commit details
    Browse the repository at this point in the history
  16. Rename SerializedAction => SerializedIsolatedActionGraph for clarity

    And more explicitly connecting it to the `IsolatedAction` concept.
    bamboo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    06e8d22 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    68f6ee5 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    0307c32 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    e220bb7 View commit details
    Browse the repository at this point in the history
  20. Polish IsolatedActionSerializer

    - Reduce visibility of `SerializedIsolatedActionGraph`
    - Better name for `toLookup`
    - Replace `if null` by `computeIfAbsent`
    bamboo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    7d324f9 View commit details
    Browse the repository at this point in the history
  21. Change :serveDocs use internal deployment API

    This makes continuous build work with serveDocs
    big-guy committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    430ff91 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    d9f2324 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    465a26f View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    cf3e989 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    0b76a9c View commit details
    Browse the repository at this point in the history
  2. Fix plugin validation error

    big-guy committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4d03352 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9cadd2c View commit details
    Browse the repository at this point in the history
  4. Accept suggestion for rewording

    Co-authored-by: Tom Tresansky <ttresansky@gradle.com>
    Signed-off-by: Sterling Greene <big-guy@users.noreply.github.com>
    big-guy and tresat committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0ef801e View commit details
    Browse the repository at this point in the history
  5. Move wiring logic to Java too

    This makes the implementation of a custom dependencies block consistently shown in Java.
    big-guy committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2518e7c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    97fa4c2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    da3d197 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7cd2260 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6cd3c47 View commit details
    Browse the repository at this point in the history
  10. Prove GradleLifecycle actions are isolated per project

    Which allows identities to be shared across different actions.
    bamboo committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2525d73 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    67d9948 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    09d5699 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ab43fba View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    a3e34cd View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    852edc0 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    6ddf968 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    3d9b39e View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    d0d7928 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    879d9eb View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    b2c07ef View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Fix flaky JavaCrossCompilationIntegrationTest

    When there are two JDKs with same major version installed,
    the test might behave flaky because it starts the test with
    
    ```
    export JAVA_HOME=/jdkPath1
    gradle run -Porg.gradle.java.installations.paths=/jdkPath2
    ```
    
    Now if the target JDK path matches current JDK version,
    we'll just use current JDK path instead of searching another Java homes.
    blindpirate authored and cobexer committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ba7ada6 View commit details
    Browse the repository at this point in the history
  2. Fix broken javadoc

    blindpirate authored and cobexer committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7aa8bcb View commit details
    Browse the repository at this point in the history
  3. Fix broken javadoc (#28878)

    cobexer committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f0f3e39 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    46ad255 View commit details
    Browse the repository at this point in the history
  5. Add required --add-opens on perf tests using Develocity

    Latest Develocity uses the new GradleLifecycle API which relies on Configuration
    Cache serialization.
    
    Configuration Cache serialization relies on reflection to serialize
    `SerializedLambda`.
    bamboo committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    45cefc0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d06d352 View commit details
    Browse the repository at this point in the history
  7. Apply suggestions from code review

    Co-authored-by: Laura Kassovic <lkassovic@gradle.com>
    Signed-off-by: Sterling Greene <big-guy@users.noreply.github.com>
    big-guy and lkasso committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9afb3dd View commit details
    Browse the repository at this point in the history
  8. Fix deadlink in new docs

    big-guy committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9988b8b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4be3019 View commit details
    Browse the repository at this point in the history
  10. Merge remote-tracking branch 'origin/release'

    * origin/release: (44 commits)
      Fix deadlink in new docs
      Apply suggestions from code review
      Add required `--add-opens` on perf tests using Develocity
      Fix broken javadoc
      Fix flaky JavaCrossCompilationIntegrationTest
      Add some minimal documentation about Daemon JVM discovery/criteria
      Change name of toolchain-version to jvm-version for UpdateDaemonJvm
      Extract JavaInstallationRegistry interface from implementation
      Make the other installation suppliers work for daemon toolchain detection too
      Move `IsolatedProject` to `org.gradle.api.project` package
      Introduce `GradleLifecycle#afterProject(IsolatedAction<Project>)`
      Reduce duplication by using a common directory for snippet example
      Prove `GradleLifecycle` actions are isolated per project
      Add convenience overloads to `AbstractIntegrationSpec#(groovy|java)File`
      Add note about the name of the dependencies block
      Make the example plugin entirely Java
      Add link to new documentation from Dependencies javadoc
      Move wiring logic to Java too
      Accept suggestion for rewording
      Fix plugin validation error
      ...
    big-guy committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    fd28462 View commit details
    Browse the repository at this point in the history