Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode helm charts dependencies in shared release workflow #3114

Merged
merged 3 commits into from
May 8, 2024

Conversation

narqo
Copy link
Contributor

@narqo narqo commented May 3, 2024

Fixes #1534

This PR updates the update-helm-repo workflow, replacing the hardcoded list of dependencies with a step that adds the dependencies from the output of the chart's helm dependency list.

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
@narqo narqo requested a review from a team as a code owner May 3, 2024 11:14
Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
@narqo narqo requested a review from krajorama May 7, 2024 12:51
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we might run into issues with repo names (conflict/not valid), but it's unlikely and then we can just name them with some foobar1 foobar2 or something

@zalegrala zalegrala merged commit 5fade78 into main May 8, 2024
6 checks passed
@zalegrala zalegrala deleted the update-helm-repo-fix-deps branch May 8, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not hardcode dependencies in common release workflow
3 participants