Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement grafana_folder_permission_item resource #1465

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Implement grafana_folder_permission_item resource #1465

merged 4 commits into from
Apr 10, 2024

Conversation

julienduchesne
Copy link
Member

Part of #1000
The _permission and role_assignement resources only allow managing the whole set of permissions/assignments

This the first of a series of new *_item resources. It's the biggest one because I had to re-implement some concepts (org ID stuff) from the legacy TF SDK

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne marked this pull request as ready for review April 4, 2024 04:04
@julienduchesne julienduchesne requested a review from a team as a code owner April 4, 2024 04:04
@julienduchesne julienduchesne force-pushed the julienduchesne/folder-permission-item branch 2 times, most recently from f3636ef to 0082f7d Compare April 4, 2024 12:53
@julienduchesne
Implement grafana_folder_permission_item resource with new framework
0869e6f 
Part of #1000
The `_permission` and `role_assignement` resources only allow managing the whole set of permissions/assignments
This the first of a series of new `*_item` resources. It's the biggest one because I had to re-implement some concepts (org ID stuff) from the legacy TF SDK
@julienduchesne
Comment out unused function
46a113f
@julienduchesne
Add example
11312c6
@julienduchesne
Fix the example
8f37a84
@julienduchesne julienduchesne force-pushed the julienduchesne/folder-permission-item branch from 0082f7d to 8f37a84 Compare April 5, 2024 16:57
julienduchesne added a commit that referenced this pull request Apr 5, 2024
@julienduchesne
Implement grafana_data_source_permission_item
4aefece 
Part of #1000
Built on top of #1465

Lots of common code between these two PRs but I'll make a lot of it common in a future PR. There is still the dashboards and service account permissions to implement
@julienduchesne julienduchesne mentioned this pull request Apr 5, 2024
Merged
julienduchesne added a commit that referenced this pull request Apr 5, 2024
@julienduchesne
Implement grafana_data_source_permission_item
9bfb0ce 
Part of #1000
Built on top of #1465

Lots of common code between these two PRs but I'll make a lot of it common in a future PR. There is still the dashboards and service account permissions to implement
julienduchesne added a commit that referenced this pull request Apr 5, 2024
@julienduchesne
Implement grafana_data_source_permission_item
b34447f 
Part of #1000
Built on top of #1465

Lots of common code between these two PRs but I'll make a lot of it common in a future PR. There is still the dashboards and service account permissions to implement
julienduchesne added a commit that referenced this pull request Apr 5, 2024
@julienduchesne
Implement grafana_data_source_permission_item
39e09a2 
Part of #1000
Built on top of #1465

Lots of common code between these two PRs but I'll make a lot of it common in a future PR. There is still the dashboards and service account permissions to implement
@julienduchesne julienduchesne changed the title Implement grafana_folder_permission_item resource with new framework Implement grafana_folder_permission_item resource Apr 8, 2024
julienduchesne added a commit that referenced this pull request Apr 8, 2024
@julienduchesne
Permission Items: Common code
771aea6 
Follow-up to #1465 and #1470
Lots of the code is exactly the same since it's the same API. This PR puts it in a common struct so that other permissions resources will be easier to add
@julienduchesne julienduchesne mentioned this pull request Apr 8, 2024
Merged
@julienduchesne julienduchesne merged commit 137c84c into main Apr 10, 2024
27 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/folder-permission-item branch April 10, 2024 12:34
julienduchesne added a commit that referenced this pull request Apr 10, 2024
@julienduchesne
Implement grafana_data_source_permission_item
2cbc58c 
Part of #1000
Built on top of #1465

Lots of common code between these two PRs but I'll make a lot of it common in a future PR. There is still the dashboards and service account permissions to implement
julienduchesne added a commit that referenced this pull request Apr 10, 2024
@julienduchesne
Implement grafana_data_source_permission_item (#1470)
cebd643 
Part of #1000
Built on top of #1465

Lots of common code between these two PRs but I'll make a lot of it common in a future PR. There is still the dashboards and service account permissions to implement
julienduchesne added a commit that referenced this pull request Apr 10, 2024
@julienduchesne
Permission Items: Common code
09e7b9c 
Follow-up to #1465 and #1470
Lots of the code is exactly the same since it's the same API. This PR puts it in a common struct so that other permissions resources will be easier to add
julienduchesne added a commit that referenced this pull request Apr 10, 2024
@julienduchesne
Permission Items: Common code (#1471)
549e3e2 
* Permission Items: Common code
Follow-up to #1465 and #1470
Lots of the code is exactly the same since it's the same API. This PR puts it in a common struct so that other permissions resources will be easier to add

* Framework doesn't support generic models

* Fix resourceType
julienduchesne added a commit that referenced this pull request Apr 11, 2024
@julienduchesne
Add grafana_service_account_permission_item resource
9799739 
Part of #1000
Just like #1465
@julienduchesne julienduchesne mentioned this pull request Apr 11, 2024
Merged
julienduchesne added a commit that referenced this pull request Apr 11, 2024
@julienduchesne
Add grafana_service_account_permission_item resource
9444418 
Part of #1000
Just like #1465
julienduchesne added a commit that referenced this pull request Apr 11, 2024
@julienduchesne
Add grafana_service_account_permission_item resource
e1872a1 
Part of #1000
Just like #1465
julienduchesne added a commit that referenced this pull request Apr 11, 2024
@julienduchesne
Add grafana_service_account_permission_item resource
70e3df9 
Part of #1000
Just like #1465
julienduchesne added a commit that referenced this pull request Apr 11, 2024
@julienduchesne
Add grafana_service_account_permission_item resource
cfdfb50 
Part of #1000
Just like #1465
julienduchesne added a commit that referenced this pull request Apr 11, 2024
@julienduchesne
Add grafana_service_account_permission_item resource (#1478)
6dcd6e6 
Part of #1000
Just like #1465
julienduchesne added a commit that referenced this pull request Apr 11, 2024
@julienduchesne
Add grafana_service_account_permission_item resource
f7cbf28 
Part of #1000
Just like #1465
@julienduchesne julienduchesne mentioned this pull request Apr 11, 2024
Merged
julienduchesne added a commit that referenced this pull request Apr 12, 2024
@julienduchesne
Add grafana_service_account_permission_item resource (#1481)
d6d9a19 
Part of #1000
Just like #1465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K-Phoen K-Phoen K-Phoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienduchesne @K-Phoen