Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data cache + batch timeout #104

Open
wants to merge 18 commits into
base: v7
Choose a base branch
from
Open

data cache + batch timeout #104

wants to merge 18 commits into from

Conversation

eaglemoor
Copy link

In this review, I added a few options:

  1. Data cache interface for the ability to wrap the batch function and its positive results in the cache. Now you can use non-memory cache, like redis or sql.
  2. Timeout for batch function. If user close context before batch func done, all data return with error and will be put in cache. WithTimeout help to wrap original context with tracing, variables, but without timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants