Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose of WebSocket when done with it #671

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Dispose of WebSocket when done with it #671

merged 3 commits into from
Dec 20, 2021

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Dec 20, 2021

No description provided.

@github-actions github-actions bot added the test label Dec 20, 2021
@STRATZ-Ken
Copy link

Can you push this to a preview build so I can test on production?

@Shane32
Copy link
Member Author

Shane32 commented Dec 20, 2021

@sungam3r Can you review this quickly?

@Shane32
Copy link
Member Author

Shane32 commented Dec 20, 2021

@sungam3r Merging now so @STRATZ-Ken can test it. Please comment when you get a chance. The API does change, but it's a non-breaking change.

@Shane32 Shane32 merged commit ecc92a3 into master Dec 20, 2021
@Shane32 Shane32 deleted the dispose_websocket branch December 20, 2021 19:44
@Shane32
Copy link
Member Author

Shane32 commented Dec 20, 2021

Published as nuget version 5.1.0-preview-127

@sungam3r
Copy link
Member

Reviewed.

@sungam3r sungam3r removed the test label Dec 20, 2021
@Shane32 Shane32 added this to the v5.2 milestone Dec 27, 2021
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 54.77%. Comparing base (857a178) to head (bc0a3ea).
Report is 276 commits behind head on master.

Files with missing lines Patch % Lines
...ts.Subscriptions.WebSockets/WebSocketConnection.cs 0.00% 8 Missing ⚠️
...rts.Subscriptions.WebSockets/WebSocketTransport.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
- Coverage   54.79%   54.77%   -0.03%     
==========================================
  Files          64       64              
  Lines        1584     1592       +8     
  Branches      158      158              
==========================================
+ Hits          868      872       +4     
- Misses        662      666       +4     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants