Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Dispose pattern for WebSocketConnection #673

Merged
merged 3 commits into from
Dec 26, 2021
Merged

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Dec 20, 2021

Unverified

No user is associated with the committer email.
@Shane32 Shane32 requested a review from sungam3r December 20, 2021 19:52
@Shane32 Shane32 self-assigned this Dec 20, 2021
@github-actions github-actions bot added the test label Dec 20, 2021
@sungam3r sungam3r added bugfix Pull request that fixes a bug and removed test labels Dec 20, 2021

Unverified

No user is associated with the committer email.
…eware.cs
@github-actions github-actions bot added the test label Dec 25, 2021
@Shane32 Shane32 requested a review from sungam3r December 25, 2021 03:25
@sungam3r sungam3r removed the test label Dec 25, 2021

Unverified

No user is associated with the committer email.
@github-actions github-actions bot added the test label Dec 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #673 (efa5737) into master (d4090a7) will decrease coverage by 0.55%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
- Coverage   55.65%   55.09%   -0.56%     
==========================================
  Files          64       64              
  Lines        1592     1590       -2     
  Branches      158      158              
==========================================
- Hits          886      876      -10     
- Misses        652      660       +8     
  Partials       54       54              
Impacted Files Coverage Δ
...riptions.WebSockets/GraphQLWebSocketsMiddleware.cs 86.48% <0.00%> (ø)
...ts.Subscriptions.WebSockets/WebSocketConnection.cs 0.00% <0.00%> (ø)
....Subscriptions.Abstractions/LogMessagesListener.cs 0.00% <0.00%> (-40.00%) ⬇️
src/Core/Extensions/ServiceCollectionExtensions.cs 56.52% <0.00%> (-26.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4090a7...efa5737. Read the comment docs.

@Shane32 Shane32 merged commit 08b16aa into master Dec 26, 2021
@Shane32 Shane32 deleted the connection_disposable branch December 26, 2021 15:56
@Shane32 Shane32 added this to the v5.2 milestone Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants