Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSourceReader has breaking behavioural changes when running on Java 16+ #2709

Open
jord1e opened this issue Feb 1, 2022 · 2 comments
Open
Labels
keep-open Tells Stale Bot to keep PRs and issues open

Comments

@jord1e
Copy link
Contributor

jord1e commented Feb 1, 2022

Describe the bug
Because of JDK-8241020 "LineNumberReader.getLineNumber() behavior is inconsistent with respect to EOF", the MultiSourceReader class behaves incorrectly when running on Java 16+ VMs, even when compiling with Java 8. This causes breaking changes.

The following test cases are failing:
afbeelding

To Reproduce

Run the tests on JDK 16, or higher
Same issue occurs when you compile on JDK 8 and run tests on JDK 16+ (see results below)

For ease of testing you may temporarily clone https://github.com/jord1e/graphql-java/tree/ci-improvements and change the versions in gradle.properties (or checkout jord1e@a1f4f84)

Results can be downloaded here:
https://github.com/jord1e/graphql-java/actions/runs/1778419182

Found whilst working on #2676

Can't figure this one out on myself quickly...

Copy link

Hello, this issue has been inactive for 60 days, so we're marking it as stale. If you would like to continue this discussion, please comment within the next 30 days or we'll close the issue.

@github-actions github-actions bot added the Stale label Nov 25, 2023
@jord1e
Copy link
Contributor Author

jord1e commented Nov 25, 2023

.

@github-actions github-actions bot removed the Stale label Nov 26, 2023
@dondonz dondonz added the keep-open Tells Stale Bot to keep PRs and issues open label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-open Tells Stale Bot to keep PRs and issues open
Projects
None yet
Development

No branches or pull requests

4 participants
@dondonz @jord1e and others