Continuous integration improvements #2789

jord1e · 2022-04-09T12:38:22Z

Does the following:

Updates GitHub Actions dependencies
Run tests on HotSpot, OpenJ9 VM,
Run tests on Ubuntu and Windows
Run tests on Java 8 (latest), 8.0.282 (earliest supported), 11 (LTS), 17 (LTS) and 18 (latest)
Compile with Java 8 and test on Java 17 (HotSpot Ubuntu)
Remove Java 8 requirement for sourceCompatibility and targetCompatibility (now resides in gradle.properties and just takes whatever J8 you have installed, or installs the latest J8)

Does not touch deployment of the jars on master, I found it kind of unnecessary because everything is done in PRs anyway and it complicates the build scripts.

This needs to be squashed before merging.

Fixed: - Generic warnings introduced in Java 9 when using `Stream#of` is used in combination with `Function.identity()`, probably caused by JEP 215 "Tiered Attribution for javac" - Java 13 introduced `String#stripIndent`, which conflicted with Groovy itself, see apache/groovy#1139, the errors were probably caused by whitespace indentation which was handled differently - Resolved compiler warning about missing `@Deprecated` on deprecated `ExecutionStepInfo#getFieldContainer` method (JDK 9/JEP 277 "Enhanced Deprecation") - The wrong `BigInteger` constructor was being used in `ScalarIntTest.groovy` and `ScalarFloatTest.groovy` Not yet fixed: - Java 16 modified LineNumberReader#getLineNumber behavior (see JDK-8241020) which messed up MultiSourceReader Links: - apache/groovy#1139 - https://bugs.openjdk.java.net/browse/JDK-8241020 - https://github.com/openjdk/jdk/commits/master/src/java.base/share/classes/java/io/LineNumberReader.java

jord1e · 2022-04-09T12:40:53Z

src/test/groovy/graphql/util/AnonymizerTest.groovy

@@ -723,39 +723,39 @@ type Object1 {

        then:
        newSchema == """\


stripIndent behaves differently on Java 16+ because it overshadows the Groovy method that was present on String before that.
By just dedenting the tests it works

Also the case for the other two tests

jord1e · 2022-04-09T12:44:52Z

.github/workflows/pull_request.yml

+      - name: Archive Gradle Test Summary
+        uses: actions/upload-artifact@v3
+        if: ${{ failure() }}
+        with:
+          name: gradle-test-summary-b${{ matrix.java.c }}-t${{ matrix.java.t || matrix.java.c }}-${{ matrix.dist.name }}-${{ matrix.os }}
+          path: build/reports/tests/test/
+          retention-days: 4
+          if-no-files-found: ignore


Example of this can be found at https://github.com/jord1e/graphql-java/actions/runs/2140596163

Go the the Artificats section, Open the .zip, then open index.html in your browser

build.gradle

dondonz · 2022-05-17T04:46:26Z

Hey @jord1e is there anything else you want to add before review?

jord1e · 2022-05-17T07:05:33Z

Hey @jord1e is there anything else you want to add before review?

No. Go ahead :)

# Conflicts: # .github/workflows/pull_request.yml # build.gradle

jord1e · 2022-07-29T13:10:49Z

@dondonz I updated the branch

jord1e · 2023-10-22T16:07:21Z

@dondonz In regards to your comment on #3031 , would you appreciate me actualizing this PR?

Just trying to figure out if it's worth investing time

yeikel · 2023-10-27T02:08:00Z

.github/workflows/pull_request.yml

+          - { c: '8.0.282', t: '8.0.282' } # Earliest supported Java 8
+          - { c: '11', t: '11' }
+          - { c: '17', t: '17' }
+          - { c: '18', t: '18' }


Given that 18 EOL was reached 1 year ago, we should be able to drop this and replace it with 17, 21, and possibly 22

now running 11,17,21

I think adding 22-ea in a new PR makes the most sense

Temurin is already releasing EA builds, we just need to make sure Semeru is excluded from the test matrix (or have includes: on 22-ea)

.github/workflows/pull_request.yml

.github/workflows/release.yml

src/test/groovy/graphql/parser/MultiSourceReaderTest.groovy

# Conflicts: # .github/workflows/master.yml # .github/workflows/pull_request.yml # .github/workflows/release.yml # settings.gradle

[skip ci]

jord1e · 2023-10-27T19:33:20Z

.github/workflows/master.yml

+      - name: Build
+        uses: gradle/gradle-build-action@v2
+        with:
+          arguments: assemble
+      - name: Test
+        uses: gradle/gradle-build-action@v2
+        with:
+          arguments: check --info
+      - name: Publish
+        uses: gradle/gradle-build-action@v2
+        with:
+          arguments: publishToSonatype closeAndReleaseSonatypeStagingRepository -x check --info --stacktrace


Facilitates better caching

jord1e · 2023-10-27T19:34:57Z

.github/workflows/release.yml

+      - name: Build
+        uses: gradle/gradle-build-action@v2
+        with:
+          arguments: assemble
+      - name: Test
+        uses: gradle/gradle-build-action@v2
+        with:
+          arguments: check --info
+      - name: Publish
+        uses: gradle/gradle-build-action@v2
+        with:
+          arguments: publishToSonatype closeAndReleaseSonatypeStagingRepository -x check --info --stacktrace


Facilitates better caching

jord1e · 2023-10-27T19:35:28Z

settings.gradle

+plugins {
+    id 'org.gradle.toolchains.foojay-resolver-convention' version '0.7.0'
+}
+


Has to be defined in the settings.gradle

Makes sure the relevant JDK is automatically downloaded again. This was changed in a more recent version (of Gradle), it used to download the JDK automatically if it was missing--now we need this plugin

jord1e · 2023-10-27T20:49:01Z

Tests >= 17 broken because of #3369

jord1e added 30 commits January 30, 2022 17:27

Update Gradle wrapper from 7.1 to 7.3.3

445932d

Test new CI file

fe0b2db

Test new CI file 2

2b73a1c

Test new CI file 3

4146505

Test new CI file 4

2245843

Test new CI file 5

61755e9

Test new CI file 6

ef7ce6f

Test new CI file 7

5bd2ba3

Correct environment variables

05c73a3

Test

7e69fcd

Test

ac7747b

Test

fa01876

Test

5d6adb8

Test

a1522d8

Test

5053eb3

Test

58b6eb5

Test

bdcdb3c

Test

3178fdc

Test

fd940e0

Test

90c43b2

Test OpenJ9

ddcb61a

Test OpenJ9 2

b524fae

Test

a8f6657

Test

eff359e

Earlier java 8

aa3c723

Earlier java 8 2

674d2a1

test

92ef37c

test

15e1621

Merge branch 'master' into ci-improvements

96cd7c5

Reset baseline to java 8

e5ce6d1

jord1e commented Apr 9, 2022

View reviewed changes

jord1e mentioned this pull request Apr 9, 2022

[WIP - DO NOT MERGE] Add CI/CD for Java {8, 11, 17, 18} x {HotSpot, OpenJ9}, fix tests #2704

Closed

jord1e commented Apr 9, 2022

View reviewed changes

build.gradle Outdated Show resolved Hide resolved

jord1e mentioned this pull request Jul 27, 2022

Shade antlr-runtime #2854

Merged

jord1e added 2 commits July 29, 2022 14:26

Merge branch 'master' into ci-improvements

7336115

# Conflicts: # .github/workflows/pull_request.yml # build.gradle

Fix tests

83ffada

jord1e mentioned this pull request Oct 26, 2022

[Feature Request] Add support for Java record types to PropertyDataFetcher #2991

Closed

dondonz mentioned this pull request Oct 26, 2023

Test using other JDK versions? #3367

Closed

yeikel reviewed Oct 27, 2023

View reviewed changes

.github/workflows/pull_request.yml Outdated Show resolved Hide resolved

yeikel reviewed Oct 27, 2023

View reviewed changes

.github/workflows/pull_request.yml Outdated Show resolved Hide resolved

yeikel reviewed Oct 27, 2023

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

yeikel reviewed Oct 27, 2023

View reviewed changes

src/test/groovy/graphql/parser/MultiSourceReaderTest.groovy Show resolved Hide resolved

jord1e added 3 commits October 27, 2023 20:42

Merge branch 'master' into ci-improvements

55fed54

# Conflicts: # .github/workflows/master.yml # .github/workflows/pull_request.yml # .github/workflows/release.yml # settings.gradle

Update Gradle to 8.4

88fb85f

[skip ci]

Fixup CI scripts

4e12c3c

jord1e commented Oct 27, 2023

View reviewed changes

jord1e mentioned this pull request Oct 27, 2023

LambdaFetchingSupport is broken for cross class loader method access after JDK >= 14 #3369

Open

Fixup test summary archive naming

f23a24f

jord1e mentioned this pull request Nov 28, 2023

Run CI on more recent Java versions and different runtimes #2676

Open

dondonz added the keep-open Tells Stale Bot to keep PRs and issues open label Dec 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Continuous integration improvements #2789

Continuous integration improvements #2789

jord1e commented Apr 9, 2022 •

edited

jord1e Apr 9, 2022

jord1e Apr 9, 2022 •

edited

dondonz commented May 17, 2022

jord1e commented May 17, 2022

jord1e commented Jul 29, 2022

jord1e commented Oct 22, 2023

yeikel Oct 27, 2023 •

edited

jord1e Oct 27, 2023

jord1e Oct 27, 2023

jord1e Oct 27, 2023

jord1e Oct 27, 2023 •

edited

jord1e commented Oct 27, 2023

Continuous integration improvements #2789

Are you sure you want to change the base?

Continuous integration improvements #2789

Conversation

jord1e commented Apr 9, 2022 • edited

jord1e Apr 9, 2022

Choose a reason for hiding this comment

jord1e Apr 9, 2022 • edited

Choose a reason for hiding this comment

dondonz commented May 17, 2022

jord1e commented May 17, 2022

jord1e commented Jul 29, 2022

jord1e commented Oct 22, 2023

yeikel Oct 27, 2023 • edited

Choose a reason for hiding this comment

jord1e Oct 27, 2023

Choose a reason for hiding this comment

jord1e Oct 27, 2023

Choose a reason for hiding this comment

jord1e Oct 27, 2023

Choose a reason for hiding this comment

jord1e Oct 27, 2023 • edited

Choose a reason for hiding this comment

jord1e commented Oct 27, 2023

jord1e commented Apr 9, 2022 •

edited

jord1e Apr 9, 2022 •

edited

yeikel Oct 27, 2023 •

edited

jord1e Oct 27, 2023 •

edited