This provides @deprecated on input fields and arguments #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
commented
Feb 6, 2021
| } else if (environment.getSource() instanceof GraphQLInputObjectField) { | ||
| GraphQLInputObjectField inputField = environment.getSource(); | ||
| } else if (type instanceof GraphQLInputObjectField) { | ||
| GraphQLInputObjectField inputField = (GraphQLInputObjectField) type; |
There was a problem hiding this comment.
just tweaked it a little bit
bbakerman
commented
Feb 6, 2021
| filtered.remove(valueDefinition); | ||
| } | ||
| } | ||
| return filtered; |
There was a problem hiding this comment.
tweaked the code to use .stream()
bbakerman
commented
Feb 6, 2021
| .type(newNonNullType(newTypeName().name("String").build()).build()) | ||
| .build()) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
removed repeated definition and re-used the other ones
|
in my team we really need this! As soon as is merged I could provide testing and feedback |
|
Love this addition! |
This was referenced Aug 3, 2021
Update dependency com.graphql-java:graphql-java to v17
graphql-java-kickstart/graphql-java-tools#560
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1770
See also https://github.com/smitt04/graphql/blob/ac15638ac02ac88013d838785d907c24bbaeff6b/spec/Section%204%20--%20Introspection.md
This now allows @deprecated to be on input fields and arguments.