Do not capture Ignored characters by default #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
commented
Jun 21, 2021
| */ | ||
| @Deprecated | ||
| protected GraphqlAntlrToLanguage getAntlrToLanguage(CommonTokenStream tokens, MultiSourceReader multiSourceReader) { |
There was a problem hiding this comment.
This was left to preserve old behavior - if some one overrides this then they can.
bbakerman
commented
Jun 21, 2021
| @@ -69,11 +71,11 @@ class ParserTest extends Specification { | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This class was littered with IDEA warnings. I clean up a lot because broken windows and all that
bbakerman
commented
Jun 21, 2021
| @@ -842,6 +844,26 @@ triple3 : """edge cases \\""" "" " \\"" \\" edge cases""" | |||
| document.getAdditionalData().get("key") == "value" | |||
| document.children[0].getAdditionalData().get("key") == "value" | |||
|
|
|||
There was a problem hiding this comment.
the old method is tested here but the diff does not show it
bbakerman
commented
Jun 21, 2021
| @@ -727,7 +729,7 @@ triple3 : """edge cases \\""" "" " \\"" \\" edge cases""" | |||
| def input = "{,\r me\n\t} ,\n" | |||
|
|
|||
| when: | |||
| Document document = new Parser().parseDocument(input) | |||
| Document document = new Parser().parseDocument(input, true) | |||
There was a problem hiding this comment.
Again the diff does not show it but this is the old ignored chars test - now needs to be ON explcitly
andimarek
approved these changes
Jun 23, 2021
This was referenced Jun 23, 2021
This was referenced Aug 3, 2021
Update dependency com.graphql-java:graphql-java to v17
graphql-java-kickstart/graphql-java-tools#560
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2207
This will save memory by default. graphql-java will not capture ignored characters by default.
A static is provided to allow a JVM wide default (set to false) or new parse methods will allow it to be explicitly set
on the parse method call