Strict boolean support for Strings in and out #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
commented
Jul 3, 2021
| if (lStr.equals("false")) { | ||
| return false; | ||
| } | ||
| return null; |
There was a problem hiding this comment.
null causes a coercing exception ins code you cant see in the diff
andimarek
approved these changes
Jul 5, 2021
This was referenced Aug 3, 2021
Update dependency com.graphql-java:graphql-java to v17
graphql-java-kickstart/graphql-java-tools#560
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a AST literal is coerced it must be
trueorfalse- easy because the parser enforces thatHowever if you use variables then
{"someBoolVar" : "TEST"}will be accepted and evaluated to false.
The old code uses Boolean.parse in Java which I have argued IS idiomatic Java however it creates strangle edge cases
We could be more strict in what we accept as a boolean.
This is that PR
If we decide to go with this PR then it would break anyone how is currently sending in strings outside "true" and "false" (case insensitive) .
See
#1103
#865