Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TS types for the new name property #331

Merged
merged 3 commits into from
Feb 2, 2023
Merged

fix: TS types for the new name property #331

merged 3 commits into from
Feb 2, 2023

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Feb 2, 2023

No description provided.

@saihaj saihaj requested a review from ardatan February 2, 2023 20:16
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e404ac2) compared to base (afa3cb3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #331   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          164       164           
  Branches        52        52           
=========================================
  Hits           164       164           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saihaj
Copy link
Member Author

saihaj commented Feb 2, 2023

@SimenB can you also take a look?

This reverts commit a012ca7.
@saihaj saihaj merged commit 6d2efb7 into main Feb 2, 2023
@SimenB
Copy link
Contributor

SimenB commented Feb 2, 2023

There should be some sort of ci for both flow and ts picking this stuff up 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants