Simplify printSchema directive printing

graphql · May 10, 2021 · 133a641 · 133a641
1 parent 78d5f83
commit 133a641
Showing 1 changed file with 6 additions and 13 deletions.
diff --git a/src/utilities/printSchema.js b/src/utilities/printSchema.js
@@ -18,7 +18,7 @@ import type {
   GraphQLInputObjectType,
 } from '../type/definition';
 import { isIntrospectionType } from '../type/introspection';
-import { GraphQLString, isSpecifiedScalarType } from '../type/scalars';
+import { isSpecifiedScalarType } from '../type/scalars';
 import {
   DEFAULT_DEPRECATION_REASON,
   isSpecifiedDirective,
@@ -32,8 +32,6 @@ import {
   isInputObjectType,
 } from '../type/definition';
 
-import { astFromValue } from './astFromValue';
-
 export function printSchema(schema: GraphQLSchema): string {
   return printFilteredSchema(
     schema,
@@ -282,9 +280,9 @@ function printDeprecated(reason: ?string): string {
   if (reason == null) {
     return '';
   }
-  const reasonAST = astFromValue(reason, GraphQLString);
-  if (reasonAST && reason !== DEFAULT_DEPRECATION_REASON) {
-    return ' @deprecated(reason: ' + print(reasonAST) + ')';
+  if (reason !== DEFAULT_DEPRECATION_REASON) {
+    const astValue = print({ kind: 'StringValue', value: reason });
+    return ` @deprecated(reason: ${astValue})`;
   }
   return ' @deprecated';
 }
@@ -293,13 +291,8 @@ function printSpecifiedByURL(scalar: GraphQLScalarType): string {
   if (scalar.specifiedByURL == null) {
     return '';
   }
-  const url = scalar.specifiedByURL;
-  const urlAST = astFromValue(url, GraphQLString);
-  invariant(
-    urlAST,
-    'Unexpected null value returned from `astFromValue` for specifiedByURL',
-  );
-  return ' @specifiedBy(url: ' + print(urlAST) + ')';
+  const astValue = print({ kind: 'StringValue', value: scalar.specifiedByURL });
+  return ` @specifiedBy(url: ${astValue})`;
 }
 
 function printDescription(