Mark user-provided 'variableValues' as read-only (#2002)

Motivation: graphql/express-graphql#516
graphql · Jun 28, 2019 · edd925b · edd925b
1 parent 9b2e626
commit edd925b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/src/execution/execute.js b/src/execution/execute.js
@@ -116,7 +116,7 @@ export type ExecutionArgs = {|
   document: DocumentNode,
   rootValue?: mixed,
   contextValue?: mixed,
-  variableValues?: ?{ [variable: string]: mixed, ... },
+  variableValues?: ?{ +[variable: string]: mixed, ... },
   operationName?: ?string,
   fieldResolver?: ?GraphQLFieldResolver<any, any>,
   typeResolver?: ?GraphQLTypeResolver<any, any>,
@@ -144,7 +144,7 @@ declare function execute(
   document: DocumentNode,
   rootValue?: mixed,
   contextValue?: mixed,
-  variableValues?: ?{ [variable: string]: mixed, ... },
+  variableValues?: ?{ +[variable: string]: mixed, ... },
   operationName?: ?string,
   fieldResolver?: ?GraphQLFieldResolver<any, any>,
   typeResolver?: ?GraphQLTypeResolver<any, any>,
@@ -266,7 +266,7 @@ export function addPath(prev: ResponsePath | void, key: string | number) {
 export function assertValidExecutionArguments(
   schema: GraphQLSchema,
   document: DocumentNode,
-  rawVariableValues: ?ObjMap<mixed>,
+  rawVariableValues: ?{ +[variable: string]: mixed, ... },
 ): void {
   invariant(document, 'Must provide document');
 
@@ -291,7 +291,7 @@ export function buildExecutionContext(
   document: DocumentNode,
   rootValue: mixed,
   contextValue: mixed,
-  rawVariableValues: ?ObjMap<mixed>,
+  rawVariableValues: ?{ +[variable: string]: mixed, ... },
   operationName: ?string,
   fieldResolver: ?GraphQLFieldResolver<any, any>,
   typeResolver?: ?GraphQLTypeResolver<any, any>,

diff --git a/src/execution/values.js b/src/execution/values.js
@@ -41,7 +41,7 @@ type CoercedVariableValues = {|
 export function getVariableValues(
   schema: GraphQLSchema,
   varDefNodes: $ReadOnlyArray<VariableDefinitionNode>,
-  inputs: ObjMap<mixed>,
+  inputs: { +[variable: string]: mixed, ... },
 ): CoercedVariableValues {
   const errors = [];
   const coercedValues = {};

diff --git a/src/graphql.js b/src/graphql.js
@@ -57,7 +57,7 @@ export type GraphQLArgs = {|
   source: string | Source,
   rootValue?: mixed,
   contextValue?: mixed,
-  variableValues?: ?{ [variable: string]: mixed, ... },
+  variableValues?: ?{ +[variable: string]: mixed, ... },
   operationName?: ?string,
   fieldResolver?: ?GraphQLFieldResolver<any, any>,
   typeResolver?: ?GraphQLTypeResolver<any, any>,
@@ -69,7 +69,7 @@ declare function graphql(
   source: Source | string,
   rootValue?: mixed,
   contextValue?: mixed,
-  variableValues?: ?{ [variable: string]: mixed, ... },
+  variableValues?: ?{ +[variable: string]: mixed, ... },
   operationName?: ?string,
   fieldResolver?: ?GraphQLFieldResolver<any, any>,
   typeResolver?: ?GraphQLTypeResolver<any, any>,
@@ -118,7 +118,7 @@ declare function graphqlSync(
   source: Source | string,
   rootValue?: mixed,
   contextValue?: mixed,
-  variableValues?: ?{ [variable: string]: mixed, ... },
+  variableValues?: ?{ +[variable: string]: mixed, ... },
   operationName?: ?string,
   fieldResolver?: ?GraphQLFieldResolver<any, any>,
   typeResolver?: ?GraphQLTypeResolver<any, any>,

diff --git a/src/subscription/subscribe.js b/src/subscription/subscribe.js
@@ -28,7 +28,7 @@ export type SubscriptionArgs = {|
   document: DocumentNode,
   rootValue?: mixed,
   contextValue?: mixed,
-  variableValues?: ?{ [variable: string]: mixed, ... },
+  variableValues?: ?{ +[variable: string]: mixed, ... },
   operationName?: ?string,
   fieldResolver?: ?GraphQLFieldResolver<any, any>,
   subscribeFieldResolver?: ?GraphQLFieldResolver<any, any>,
@@ -64,7 +64,7 @@ declare function subscribe(
   document: DocumentNode,
   rootValue?: mixed,
   contextValue?: mixed,
-  variableValues?: ?{ [variable: string]: mixed, ... },
+  variableValues?: ?{ +[variable: string]: mixed, ... },
   operationName?: ?string,
   fieldResolver?: ?GraphQLFieldResolver<any, any>,
   subscribeFieldResolver?: ?GraphQLFieldResolver<any, any>,
@@ -187,7 +187,7 @@ export function createSourceEventStream(
   document: DocumentNode,
   rootValue?: mixed,
   contextValue?: mixed,
-  variableValues?: ?{ [variable: string]: mixed, ... },
+  variableValues?: ?{ +[variable: string]: mixed, ... },
   operationName?: ?string,
   fieldResolver?: ?GraphQLFieldResolver<any, any>,
 ): Promise<AsyncIterable<mixed> | ExecutionResult> {