validation: Export rules missing in <14.6.0 using legacy names #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's recommended to update to 14.6.0 and start using correct exports added in graphql#2400 but if you stuck on the earlier version you can use these exports as a temporary workaround. Note: these exports are deprecated and will be removed in v16
IvanGoncharov
added
the
PR: feature 🚀
|
@trevor-scheer Can you please review it? |
There was a problem hiding this comment.
LGTM, thanks!
For anyone else curious why some of the rules in this change aren't updated / supported, they should be exported from the top-level with the Rule suffix already.
For example, for our use case we previously had:
import { UniqueTypeNames } from 'graphql/validation/rules/UniqueTypeNames';Which becomes:
import { UniqueTypeNamesRule } from 'graphql';
trevor-scheer
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jan 30, 2020
This update is in response to the following PRs: graphql/graphql-js#2400 graphql/graphql-js#2413
abernix
pushed a commit
to apollographql/apollo-server
that referenced
this pull request
Jan 31, 2020
This update is in response to the below referenced PRs. The `UniqueDirectivesPerLocationRule` has been exported at the root since forever (at least 0.12.0. graphql/graphql-js#2400 graphql/graphql-js#2413
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…ver#3741) This update is in response to the below referenced PRs. The `UniqueDirectivesPerLocationRule` has been exported at the root since forever (at least 0.12.0. graphql/graphql-js#2400 graphql/graphql-js#2413 Apollo-Orig-Commit-AS: apollographql/apollo-server@5e9054c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's recommended to update to 14.6.0 and start using correct exports
added in #2400 but if you stuck on the earlier version you could use these
exports as a temporary workaround.
Note: these exports are deprecated and will be removed in v16