fix: change OperationTypeNode to enum #2887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes OperationTypeNode to enum instead of a union type. This allows developers to use the type as `OperationTypeNode.QUERY` instead of risking to msispell the string 'query'. Example: Instead of having to write `operation === 'query'` you can instead write `operation === OperationTypeNode.QUERY` This should not be a breaking change, since the string version should still work.
IvanGoncharov
added
the
PR: polish 💅
saihaj
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
Thanks @lekoaf! can you please rebase this. Then @IvanGoncharov we can merge this
|
Now that TS migration is done, this can perhaps be included in v16? Is there a reason this was held up? |
Yupp, I missed the rebase comment. I'll do that tomorrow. 😃 |
|
I'm closing this because I didn't manage to rebase after all the changes. Most of all the base branch name. Please see #3312 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes OperationTypeNode to enum instead of a union type. This allows developers to use the type as
OperationTypeNode.QUERYinstead of risking to msispell the string 'query'.Example:
Instead of having to write
operation === 'query'you can instead write
operation === OperationTypeNode.QUERYThis should not be a breaking change, since the string version should still work.