language: change OperationTypeNode to enum #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hmm, according to the linter, this may be a breaking change after all? |
|
I think you just need to replace all places where we return string to return values from this |
lekoaf
force-pushed
the
mt/operationTypeNode_enum
branch
from
85a1fee
to
c933764
Compare
Changes OperationTypeNode to enum instead of a union type. This allows developers to use the type as `OperationTypeNode.QUERY` instead of risking to msispell the string 'query'. Example: Instead of having to write `operation === 'query'` you can instead write `operation === OperationTypeNode.QUERY`
lekoaf
force-pushed
the
mt/operationTypeNode_enum
branch
from
c933764
to
c726830
Compare
IvanGoncharov
added
the
PR: feature 🚀
IvanGoncharov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes OperationTypeNode to enum instead of a union type.
This allows developers to use the type as
OperationTypeNode.QUERYinstead of risking to msispell the string 'query'.
Example:
Instead of having to write
operation === 'query'you can instead write
operation === OperationTypeNode.QUERY(This is a continuation of #2887)