resolveType: remove support for returning GraphQLObjectType #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added
the
PR: breaking change 💥
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Feb 20, 2021
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
May 24, 2021
It became out of date after graphql#2905
10 tasks
|
The documentation was not updated |
|
@boetersep yeah we are running very behind on apps. We have a new site which should be landing soon which provides TS Docs api #3269 |
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
Dec 20, 2021
...as opposed to just type names. This reverts graphql#2905 This change was made upstream to support schema transformation functions like lexicographicallySortSchema which do not modify resolveType methods. Previously, a workaround was included that simply looks up the actual type from the type name returned by resolveType. In actuality, in my opinion, the schema transformation functions should natively or manually modify the resolveType function so it works correctly. In any case, we restore the workaround here to preserve v14 support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.