Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parser location API #3061

Merged
merged 1 commit into from May 6, 2021
Merged

Improve parser location API #3061

merged 1 commit into from May 6, 2021

Conversation

leebyron
Copy link
Contributor

@leebyron leebyron commented May 6, 2021

This replaces manual assignment of loc on each node in Parser with a node() function. This simplifies the parser and also ensures the loc field does not appear at all when noLocation is provided.

This replaces manual assignment of `loc` on each node in Parser with a `node()` function. This simplifies the parser and also ensures the `loc` field does not appear at all when `noLocation` is provided.
@leebyron leebyron merged commit 002fb91 into main May 6, 2021
@leebyron leebyron deleted the parser-loc branch May 6, 2021 03:43
leebyron added a commit that referenced this pull request May 6, 2021
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants