Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: force proper typing on version literals #3344

Merged
merged 2 commits into from Oct 28, 2021

Conversation

IvanGoncharov
Copy link
Member

Types should be generic and stay the same across different versions
E.g. preReleaseTag should be typed string | null even if it's a
null literal for this particular release

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Oct 28, 2021
Types should be generic and stay the same across different versions
E.g. `preReleaseTag` should be typed `string | null` even if it's a
`null` literal for this particular release
@IvanGoncharov IvanGoncharov marked this pull request as ready for review October 28, 2021 19:20
@IvanGoncharov IvanGoncharov merged commit 2831917 into graphql:main Oct 28, 2021
@IvanGoncharov IvanGoncharov deleted the pr_branch branch October 28, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant