Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version: force proper typing on version literals #3344

Merged
merged 2 commits into from Oct 28, 2021
Merged

version: force proper typing on version literals #3344

merged 2 commits into from Oct 28, 2021

Commits on Oct 28, 2021

  1. version: force proper typing on version literals 

    Types should be generic and stay the same across different versions
E.g. `preReleaseTag` should be typed `string | null` even if it's a
`null` literal for this particular release
    @IvanGoncharov
    IvanGoncharov committed Oct 28, 2021
    Copy the full SHA
    4e2b74e View commit details
    Browse the repository at this point in the history

  2. build-npm: fix type inference during TS declarations build

    @IvanGoncharov
    IvanGoncharov committed Oct 28, 2021
    Copy the full SHA
    da23abc View commit details
    Browse the repository at this point in the history