instanceOf: workaround bundler issue with process.env
#3923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big shout out to @phryneas, who managed to reproduce this issue and come up with this fix.
Fixes: #3919 #3920 #3921
Context: #3887 changed code and introced optinal chaining.
globalThis.process?.env.NODE_ENV
is transpiled intoBundlers incorrectly replace (probably RegExp)
process.env.NODE_ENV
with"development"
resulting in:Technically it's not a graphql issue but an issue with bundler but since it caused so much pain in comutinity this is an attempt to fix it within our codebase.