fix(jsutils): use optional chaining to prevent crash in browser #4017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We use contentful/live-preview. The library has
graphql-js
as a dependency.Problem
If the DOM has an element with
id="process"
eg.<div id="process"></div>
than the current implementation ofutils/instanceOf
would fail.Current implementation:
with this implementation
globalThis.process
will return the DOM element:Because
globalThis.process is true
, the conditionglobalThis.process.env.NODE_ENV === 'production'
gets executed and will result with an javascript error: