Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Allow full unicode range #849

Merged
merged 3 commits into from Jun 3, 2022
Merged

RFC: Allow full unicode range #849

merged 3 commits into from Jun 3, 2022

Commits on Jun 2, 2022

  1. RFC: Allow full unicode range 

    This spec text implements #687 (full context and details there) and also introduces a new escape sequence.

Three distinct changes:

1. Change SourceCharacter to allow points above 0xFFFF, now to 0x10FFFF.
2. Allow surrogate pairs within StringValue. This handles illegal pairs with a parse error.
3. Introduce new syntax for full range code point EscapedUnicode. This syntax (`\u{1F37A}`) has been adopted by many other languages and I propose GraphQL adopt it as well.

(As a bonus, this removes the last instance of a regex in the lexer grammar!)
    @leebyron
    leebyron committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    5e5c3cd View commit details
    Browse the repository at this point in the history

  2. Revised RFC after feedback 

    Co-authored-by: Andreas Marek <andimarek@fastmail.fm>
    @leebyron @andimarek
    leebyron and andimarek committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    cfce61e View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Editorial

    @leebyron
    leebyron committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    6871305 View commit details
    Browse the repository at this point in the history