Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation about argument name uniqueness. #891

Merged

Conversation

dugenkui03
Copy link
Contributor

@dugenkui03 dugenkui03 commented Oct 7, 2021

Details in #739.

@netlify
Copy link

netlify bot commented Oct 7, 2021

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 10bb59a
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/63cae4e90a1e3b000804d3bc
😎 Deploy Preview https://deploy-preview-891--graphql-spec-draft.netlify.app/draft
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@IvanGoncharov
Copy link
Member

Background graphql/graphql-wg#505
graphql-js PR graphql/graphql-js#3208

@IvanGoncharov
Copy link
Member

I think we are ready to move it to Stage2, but we still, need to follow the procedure and present it on WG.
@dugenkui03 Can you join WG today?
https://github.com/graphql/graphql-wg/blob/main/agendas/2021-10-07.md
I expect it to be a very short discussion so if you can't make it, I can present it.

@dugenkui03
Copy link
Contributor Author

dugenkui03 commented Oct 7, 2021

I think we are ready to move it to Stage2, but we still, need to follow the procedure and present it on WG. @dugenkui03 Can you join WG today? https://github.com/graphql/graphql-wg/blob/main/agendas/2021-10-07.md I expect it to be a very short discussion so if you can't make it, I can present it.

@IvanGoncharov Thank you so much that you can present it , my spoken english is not so good. I'd like join the meeting.

@benjie
Copy link
Member

benjie commented Oct 7, 2021

@dugenkui03 Please add yourself to the agenda if you wish to attend, you do not need to speak other than introducing yourself at the beginning (and we can make an exception for that if you like?). If you wish, you may type into the Zoom chat and someone can read that out on your behalf.

@dugenkui03
Copy link
Contributor Author

dugenkui03 commented Oct 7, 2021

@benjie The PR was created to add myself to agenda, and I am glad to introduce myself briefly.

Copy link
Contributor

@mjmahone mjmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go for the next WG, in my opinion: we should merge it in! It looks like @IvanGoncharov already created the rule for graphql-js in graphql/graphql-js#3208, so I hope we can wrap this up quickly.

@benjie
Copy link
Member

benjie commented Nov 29, 2021

Can someone add it to the next WG agenda?

@benjie benjie force-pushed the moreDetailAboutArgumentNameUniquess branch from b2742e3 to 10bb59a Compare January 20, 2023 19:00
@benjie
Copy link
Member

benjie commented Jan 20, 2023

I've merged the latest, did some tiny edits, and have added it to the next WG.

Copy link
Contributor

@mjmahone mjmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels clear

@leebyron leebyron added 🏁 Accepted (RFC 3) RFC Stage 3 (See CONTRIBUTING.md) and removed 📄 Draft (RFC 2) RFC Stage 2 (See CONTRIBUTING.md) labels Feb 2, 2023
@leebyron leebyron merged commit 12b7ad7 into graphql:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Accepted (RFC 3) RFC Stage 3 (See CONTRIBUTING.md)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants