Revise the New Project form #4130

mattbk · 2016-09-22T19:33:14Z

Derived from #4123.

Stubbing this out, need to be on front of a local install before I can do more (aside from learning Aspen).

Make sure Homepage is URL (turned off for the moment).
Enable ~~team~~ project editing while retaining those fields for ~~teams~~ projects that already exist.
Fix tests that I'm sure will be broken.
Remove notice about tip migration, per phase out tip migration inside.gratipay.com#536 —done in Remove tips from the UI #4219

chadwhitacre · 2016-09-22T21:57:26Z

🌻 💃

mattbk · 2016-09-25T01:35:15Z

Hmm.

This will be harder than I thought.

mattbk · 2016-10-10T20:48:01Z

I'm reversing what I said over at #4123 (comment) (and not only because it's less work to leave all the fields in place).

Although if we leave the onboarding and TWYW fields (as optional), we'll need to adjust what "Approved" means, and tie approval only to TOS+fit; this still applies:

We should keep track of those projects that are already "open work" approved, so we can grandfather them in when we get to that (which I suppose could just be a list on a ticket somewhere, rather than dumping it into the database right now).

In light of #4135, though, we might as well keep open work as the beginning of the levels idea, and add an open_work database field so we can show/rank those teams on the homepage.

This is happening at the same time as we're moving toward #BackTheStack (corporate sponsorship of projects), but I think it's important to keep this long tail going.

mattbk · 2016-10-10T21:58:17Z

So it could be something like:

Basics (required)
- Team name
- Image
- Product or service
- Homepage
- Agree to public review
  - Include why this is, link to TOS/brand guidelines.
- Agree to TOS
Open work fields (optional)
- Include short sentence explaining open work, with links. Open work criteria will be reviewed after project is approved, but is no longer required for a project to be approved.
- Onboarding URL
- Todo URL
TWYW fields (optional)
- TWYW doesn't exist yet under Gratipay 2.0. Check this box if you're interested in being notified.
- Agree to ~~Payroll~~ TWYW payouts

chadwhitacre · 2016-11-22T02:15:24Z

Rebased on latest master. Previous head was 2b458cd.

@JessaWitzel Wanna work on this one together with @mattbk? :-)

chadwhitacre · 2016-11-22T02:18:30Z

TWYW fields (optional)

I think we should kill this part entirely, because we're so far away from bringing that back.

Todo URL

Let's drop this per #4166.

That should leave onboarding as the only optional field, ya?

JessaWitzel · 2016-11-28T02:03:42Z

How can I help?

mattbk · 2016-11-28T02:30:53Z

@JessaWitzel, it looks like the onboarding field needs to go back in (revert part of 565dac0), and then the other checklist items in the first post, if you agree with them. I'm not the greatest with tests. Feel free to jump in and make commits.

chadwhitacre · 2016-11-30T14:21:46Z

Bringing over from #4166:

The three separate checkboxes. Why not implicitly tick them (with the wording "When you click on 'Apply', you agree to x, y and z" when the user clicks on 'Apply'? Reference: http://ux.stackexchange.com/questions/55571/auto-agreement-to-the-tos-by-clicking-sign-up-button-in-sign-up-form

chadwhitacre · 2016-11-30T14:41:57Z

TWYW fields (optional)

I think we should kill this part entirely, because we're so far away from bringing that back.

This takes us down to two checkboxes. I think the public review thing is unusual enough that it's worth elevating to its own checkbox. We could tweak the wording of the second to say "other terms of service." Nobody reads the terms because they assume there won't be any surprises, but we have some weird stuff in ours.

mattbk · 2016-12-01T20:35:21Z

Is this PR necessary if we have #4214?

I'm a little confused as to what needs to be done now.

JessaWitzel · 2016-12-02T03:29:41Z

@whit537 are projects different than teams?

mattbk · 2016-12-02T13:06:31Z

Teams are being renamed to projects.

chadwhitacre · 2016-12-06T13:38:53Z

Rebased; was 565dac0.

chadwhitacre · 2016-12-06T13:51:36Z

Base changed to remove-todo-url (#4214) since that is scheduled to land in #4221 first.

chadwhitacre · 2016-12-06T13:52:09Z

Of course that means Travis won't see us again ... :/

mattbk · 2016-12-09T01:22:16Z

I left it in the database. Everything else is pulled out.

chadwhitacre · 2016-12-09T10:53:04Z

www/%team/edit/edit.json.spt

@@ -53,7 +53,7 @@ for field in data.keys():
            if not value:
                raise Response(400, _("Please fill out the '{}' field.", field_names[field]))

-            if (field in ('homepage', 'onboarding_url')
+            if (field in ('homepage')


This is now the same as field in 'homepage' because of the way parens work in Python (without a comma they're used for grouping, with a comma they make a tuple). Probably should rework to just be if field == 'homepage'.

chadwhitacre · 2016-12-09T15:50:01Z

Hmm ... Travis failures?

chadwhitacre · 2016-12-09T16:05:58Z

They're all choking on oniguruma when installing marky-markdown (except for one which is weird).

chadwhitacre · 2016-12-09T16:06:47Z

Did oniguruma just put out a new version?

chadwhitacre · 2016-12-09T16:07:44Z

Version 6.1.1 worked in the one build that worked.

https://travis-ci.org/gratipay/gratipay.com/builds/182613635

chadwhitacre · 2016-12-09T16:09:29Z

travis-ci/travis-ci#4771 😖

chadwhitacre · 2016-12-09T16:17:38Z

Fail!

Latest

gyp WARN install got an error, rolling back install
gyp ERR! configure error 
gyp ERR! stack Error: 522 status code downloading tarball
gyp ERR! stack     at Request.<anonymous> (/home/travis/.nvm/v0.10.36/lib/node_modules/npm/node_modules/node-gyp/lib/install.js:246:14)
gyp ERR! stack     at Request.emit (events.js:117:20)
gyp ERR! stack     at Request.onResponse (/home/travis/.nvm/v0.10.36/lib/node_modules/npm/node_modules/request/request.js:1085:10)
gyp ERR! stack     at ClientRequest.g (events.js:180:16)
gyp ERR! stack     at ClientRequest.emit (events.js:95:17)
gyp ERR! stack     at HTTPParser.parserOnIncomingClient (http.js:1693:21)
gyp ERR! stack     at HTTPParser.parserOnHeadersComplete [as onHeadersComplete] (http.js:122:23)
gyp ERR! stack     at Socket.socketOnData (http.js:1588:20)
gyp ERR! stack     at TCP.onread (net.js:528:27)

Earliest

gyp WARN install got an error, rolling back install
gyp ERR! configure error 
gyp ERR! stack Error: node-v0.10.36.tar.gz local checksum 6fd25f1e62f2e0d257a8c1ad8df2da088ebd4b1cd9e188a2fca510a31a559de7 not match remote b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81
gyp ERR! stack     at deref (/home/travis/.nvm/v0.10.36/lib/node_modules/npm/node_modules/node-gyp/lib/install.js:299:20)
gyp ERR! stack     at IncomingMessage.<anonymous> (/home/travis/.nvm/v0.10.36/lib/node_modules/npm/node_modules/node-gyp/lib/install.js:340:13)
gyp ERR! stack     at IncomingMessage.emit (events.js:117:20)
gyp ERR! stack     at _stream_readable.js:944:16
gyp ERR! stack     at process._tickCallback (node.js:442:13)

chadwhitacre · 2016-12-09T16:19:01Z

Alright, so it looks like it's a problem downloading the tarball, not building it. Backing out 5bc1bc0 …

chadwhitacre · 2016-12-09T16:25:07Z

nodejs/node-gyp#693 ?

chadwhitacre · 2016-12-09T16:29:28Z

build	error
182606728	node-v0.10.36.tar.gz local checksum [] not match remote []
182606710	node-v0.10.36.tar.gz local checksum [] not match remote []
182613462	node-v0.10.36.tar.gz local checksum [] not match remote []
182613635
182622559	Completion callback never invoked!
182622533	node-v0.10.36.tar.gz local checksum [] not match remote []
182623387	node-v0.10.36.tar.gz local checksum [] not match remote []
182635391	522 status code downloading tarball

chadwhitacre · 2016-12-09T16:30:09Z

http://status.npmjs.org/ shows green

chadwhitacre · 2016-12-09T16:31:02Z

The local checksum is different in all of the checksum failed cases, while the remote is the same in all cases.

chadwhitacre · 2016-12-09T16:35:21Z

Why are we using such an ancient version of node?

chadwhitacre · 2016-12-09T16:37:56Z

It's probably the system version on whatever Ubuntu we get there? Let's try installing a more recent version ...

chadwhitacre · 2016-12-09T16:42:04Z

we are having issues with our download service right now. hoping to have it sorted out very soon

nodejs/node-gyp#693 (comment)

chadwhitacre · 2016-12-09T16:48:10Z

The build passed! But not because of 4295843; I only see python in the "Build system information" there (and it seems multiple languages aren't directly supported: travis-ci/travis-ci#4090). Gonna push that off and see if we still pass.

chadwhitacre · 2016-12-09T16:54:02Z

Still passing! Merging while we have a chance. ;-)

chadwhitacre · 2016-12-09T16:54:19Z

!m @mattbk

mattbk added this to the Decouple milestone Sep 22, 2016

chadwhitacre mentioned this pull request Sep 22, 2016

Core Radar 77 gratipay/inside.gratipay.com#821

Closed

mattbk mentioned this pull request Sep 25, 2016

Talk about revising the team application #4123

Closed

chadwhitacre mentioned this pull request Oct 22, 2016

Relax Open Work Requirement gratipay/inside.gratipay.com#432

Closed

mattbk mentioned this pull request Nov 7, 2016

Make agreement to TOS implicit in clicking "Apply" #4166

Closed

chadwhitacre force-pushed the new-project branch from 2b458cd to 565dac0 Compare November 22, 2016 02:18

chadwhitacre mentioned this pull request Nov 22, 2016

Onboard @JessaWitzel gratipay/inside.gratipay.com#866

Closed

chadwhitacre mentioned this pull request Nov 30, 2016

Remove the To-do URL #4214

Merged

2 tasks

chadwhitacre mentioned this pull request Dec 2, 2016

phase out tip migration gratipay/inside.gratipay.com#536

Closed

chadwhitacre changed the base branch from master to relax-open-work-requirement December 2, 2016 21:23

chadwhitacre mentioned this pull request Dec 6, 2016

Relax open work requirement #4221

Merged

21 tasks

chadwhitacre force-pushed the new-project branch from 565dac0 to 046ae64 Compare December 6, 2016 13:38

chadwhitacre changed the base branch from relax-open-work-requirement to remove-todo-url December 6, 2016 13:50

chadwhitacre force-pushed the remove-todo-url branch from ec21796 to 8db0601 Compare December 6, 2016 13:54

mattbk added the Review label Dec 9, 2016

chadwhitacre reviewed Dec 9, 2016

View reviewed changes

mattbk and others added 4 commits December 9, 2016 08:40

Fix homepage if.

792d759

Update the edit form to match the application

b9f3f99

Fix formatting in test_team_edit

5f25219

Remove onboarding_url from test_team_edit

102ab69

chadwhitacre force-pushed the new-project branch from 5bc1bc0 to 102ab69 Compare December 9, 2016 16:19

chadwhitacre mentioned this pull request Dec 9, 2016

local checksum not match remote while node-gyp install nodejs/node-gyp#693

Closed

chadwhitacre force-pushed the new-project branch from 4295843 to 102ab69 Compare December 9, 2016 16:48

chadwhitacre merged commit 53146a6 into relax-open-work-requirement Dec 9, 2016

chadwhitacre pushed a commit that referenced this pull request Dec 9, 2016

Revise the New Project form (#4130)

698712d

chadwhitacre deleted the new-project branch December 13, 2016 03:07

Revise the New Project form #4130

Revise the New Project form #4130

Conversation

mattbk commented Sep 22, 2016 • edited by chadwhitacre

chadwhitacre commented Sep 22, 2016

mattbk commented Sep 25, 2016 • edited

mattbk commented Oct 10, 2016 • edited

mattbk commented Oct 10, 2016

chadwhitacre commented Nov 22, 2016

chadwhitacre commented Nov 22, 2016

JessaWitzel commented Nov 28, 2016

mattbk commented Nov 28, 2016

chadwhitacre commented Nov 30, 2016

chadwhitacre commented Nov 30, 2016 • edited

mattbk commented Dec 1, 2016

JessaWitzel commented Dec 2, 2016

mattbk commented Dec 2, 2016

chadwhitacre commented Dec 6, 2016

chadwhitacre commented Dec 6, 2016

chadwhitacre commented Dec 6, 2016

mattbk commented Dec 9, 2016

chadwhitacre Dec 9, 2016

Choose a reason for hiding this comment

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

Latest

Earliest

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

chadwhitacre commented Dec 9, 2016

mattbk commented Sep 22, 2016 •

edited by chadwhitacre

mattbk commented Sep 25, 2016 •

edited

mattbk commented Oct 10, 2016 •

edited

chadwhitacre commented Nov 30, 2016 •

edited