Remove the To-do URL #4214

chadwhitacre · 2016-11-30T13:56:40Z

Closes #4166; part of #4130.

Todo

use a branch.sql—Remove the To-do URL #4214 (comment)
fix formatting niggle—Remove the To-do URL #4214 (comment)

chadwhitacre · 2016-11-30T14:36:04Z

Okay @JessaWitzel, this one's for you (ref)! :-)

Your first PR was for inside.gratipay.com ... this one is gonna be your first PR for gratipay.com itself! 💃

Here's what we are looking for here:

spin up your local environment to the point where you can see and submit the "Apply for a New Team" form locally—that's what you'll be working on here
find and remove the "To-do URL" field from the form
also remove the todo_url field from the teams table in the database
make sure the tests still pass
make sure the form still works

Does that give you enough to get started? For broader context, check the project linked in the sidebar here on GitHub (and check the "Details" on the project page). As always, if you're stuck after an hour, ask us a question here or on slack! Okay! Good luck! 👍 💃 🌻

JessaWitzel · 2016-11-30T19:14:52Z

Have removed the to-do URL field from the form and the field from the teams table (I think) but when I try to create a team locally I receive gratipay.com/error.spt "Please fill out the 'To-do URL' field." Went into testing and removed the todo_url test but am still receiving error.

chadwhitacre · 2016-11-30T19:51:08Z

slack

mattbk · 2016-11-30T20:07:58Z

This is how I like to solve problems like this: https://github.com/gratipay/gratipay.com/search?utf8=%E2%9C%93&q=Please+fill+out+the+%27To-do+URL%27+field.

(You can ignore i18n files, they are generated for translations.)

JessaWitzel · 2016-11-30T23:16:25Z

The tests worked for a minute but then I had to clean and re: make schema make fake and the fake data was wrong. Now I am receiving a subprocess error when I try to run tests that stalls on the first test related to honcho?

JessaWitzel · 2016-12-01T06:21:56Z

Why does make test have so many more failures than make pytest? This passes when I make pytest.

JessaWitzel · 2016-12-01T06:43:46Z

I ended up removing all references to todo_url in the code, not just those related to the form because it didn't pass tests until I did. I hope that is what you wanted. :)

chadwhitacre · 2016-12-01T14:02:47Z

!m @JessaWitzel

I see the tasks are ticked in #4214 (comment). Does that mean you're done here? If so, go ahead and move it to the "Landing" column on the project (see sidebar) and then ping a few of us here by name to let us know it's ready for review! :)

JessaWitzel · 2016-12-01T15:35:38Z

Ready for review friends! @whit537 @mattbk @clone1018

mattbk · 2016-12-02T01:50:47Z

I got this when I submitted:

JessaWitzel · 2016-12-02T03:05:38Z

You know what? I fixed that and then after all of the testing errors I had to redo some things and never checked to see if I could submit the form. I will fix.

JessaWitzel · 2016-12-02T03:26:13Z

After cleaning my environment and removing cached files, the form works for me. Can you try that?

mattbk · 2016-12-02T03:38:39Z

Success after make clean env!

chadwhitacre · 2016-12-02T13:19:31Z

sql/schema.sql

@@ -546,7 +546,6 @@ BEGIN;
    ALTER TABLE teams ALTER COLUMN getting_paid DROP NOT NULL;

    ALTER TABLE teams ADD COLUMN onboarding_url text NOT NULL DEFAULT '';
-    ALTER TABLE teams ADD COLUMN todo_url text NOT NULL DEFAULT '';


Soooo ... schema.sql is append-only. We shouldn't delete from it like this. Check in the README for how to modify the database. As usual, ping me/us if you get stuck. :-)

Apologies. There is so much to remember!

No apologies necessary! You're doing great! :-)

chadwhitacre · 2016-12-02T13:20:25Z

tests/py/test_teams.py

-                          , onboarding_url='http://INSIDE.GRATipay.com/'
-                          , todo_url='hTTPS://github.com/GRATIPAY'
-                           ))
+                          , onboarding_url='http://INSIDE.GRATipay.com/'))


Sorry to be picky but can we match the parentheses formatting here as it was before? :)

Fixed in 6062804. :-)

chadwhitacre · 2016-12-02T13:27:47Z

Looks good so far, @JessaWitzel! Good work! 💃

I was able to submit the form locally. 👍

I've left a couple todos (in the ticket description), one tiny and one more involved.

chadwhitacre · 2016-12-05T16:45:27Z

sql/schema.sql

+--https://github.com/gratipay/gratipay.com/pull/4214
+BEGIN;
+  ALTER TABLE teams DROP COLUMN todo_url;
+END;


@JessaWitzel Close! Rather than modifying sql/schema.sql directly, what we want is a file at sql/branch.sql (it shouldn't exist on your branch; you have to create it and add it to Git). If there's a file at sql/branch.sql then our deploy script takes care of appending it to sql/schema.sql after running sql/branch.sql against the production database. Make sense?

Makes sense. Thank you!

chadwhitacre · 2016-12-07T02:59:36Z

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

chadwhitacre · 2016-12-07T03:00:14Z

Aaaaaaaand #4224. 😩

chadwhitacre · 2016-12-07T19:48:23Z

Returning from #4224 ...

chadwhitacre · 2016-12-07T19:49:26Z

Builds restarted. Will it be as simple as that?

chadwhitacre · 2016-12-07T19:54:36Z

Green! Let's see if we can land this ...

chadwhitacre · 2016-12-07T19:55:12Z

Rebased, was 2596672.

chadwhitacre · 2016-12-07T20:17:46Z

Hit #4224. Cache cleared for this PR and build restarted ...

chadwhitacre · 2016-12-07T20:19:00Z

I removed the caches for remove-todo-url and relax-open-work-requirement for good measure. I left master.

chadwhitacre · 2016-12-07T20:25:03Z

Looks like it's working! 💃

chadwhitacre · 2016-12-07T20:53:43Z

I accidentally rebased 2596672 away! Brought it back with:

wget https://github.com/gratipay/gratipay.com/commit/2596672a354b0fb4518971cda8024e816979d7a8.patch
git am 2596672a354b0fb4518971cda8024e816979d7a8.patch

chadwhitacre · 2016-12-07T20:58:58Z

Woo-hoo! Good work, @JessaWitzel! 💃 🌻

chadwhitacre changed the title ~~Removing the todo URL~~ Remove the todo URL Nov 30, 2016

chadwhitacre changed the title ~~Remove the todo URL~~ Remove the To-do URL Nov 30, 2016

JessaWitzel mentioned this pull request Dec 1, 2016

Testing Problems #4216

Closed

JessaWitzel added a commit that referenced this pull request Dec 1, 2016

issue #4214

cd10e06

mattbk mentioned this pull request Dec 1, 2016

Revise the New Project form #4130

Merged

4 tasks

mattbk added the Review label Dec 2, 2016

JessaWitzel removed the Review label Dec 2, 2016

JessaWitzel added the Review label Dec 2, 2016

chadwhitacre commented Dec 2, 2016

View reviewed changes

chadwhitacre removed the Review label Dec 2, 2016

chadwhitacre changed the base branch from master to relax-open-work-requirement December 2, 2016 21:23

mattbk added the Review label Dec 4, 2016

chadwhitacre commented Dec 5, 2016

View reviewed changes

chadwhitacre force-pushed the remove-todo-url branch from 2fcc8a3 to 88226c1 Compare December 5, 2016 16:47

chadwhitacre pushed a commit that referenced this pull request Dec 5, 2016

issue #4214

af0022e

chadwhitacre force-pushed the remove-todo-url branch from 8db0601 to 0c1252c Compare December 6, 2016 14:08

chadwhitacre pushed a commit that referenced this pull request Dec 6, 2016

issue #4214

6b357c8

chadwhitacre mentioned this pull request Dec 6, 2016

Fix fake payment instruction #4224

Merged

chadwhitacre force-pushed the relax-open-work-requirement branch from c2644b5 to cb71c2a Compare December 7, 2016 19:53

chadwhitacre force-pushed the remove-todo-url branch from 2596672 to 6b5e2cc Compare December 7, 2016 19:55

chadwhitacre pushed a commit that referenced this pull request Dec 7, 2016

issue #4214

47d296a

chadwhitacre force-pushed the relax-open-work-requirement branch 3 times, most recently from 1619f84 to cf13cc6 Compare December 7, 2016 20:03

JessaWitzel and others added 5 commits December 7, 2016 15:03

fake data

76c7d79

issue #4214

22bbf9a

Twitch, twitch

4a151f7

Adding ALTER to DROP todo_url column

2749c4b

add branch.sql to alter schema.sql

8da9b4d

chadwhitacre force-pushed the remove-todo-url branch from 6b5e2cc to 8da9b4d Compare December 7, 2016 20:03

Back out .sql changes

e12e185

chadwhitacre merged commit 25018df into relax-open-work-requirement Dec 7, 2016

chadwhitacre added a commit that referenced this pull request Dec 8, 2016

Remove the To-do URL (#4214)

ab63da0

chadwhitacre deleted the remove-todo-url branch January 2, 2017 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the To-do URL #4214

Remove the To-do URL #4214

chadwhitacre commented Nov 30, 2016 •

edited by JessaWitzel

chadwhitacre commented Nov 30, 2016 •

edited by JessaWitzel

JessaWitzel commented Nov 30, 2016

chadwhitacre commented Nov 30, 2016 •

edited

mattbk commented Nov 30, 2016 •

edited

JessaWitzel commented Nov 30, 2016

JessaWitzel commented Dec 1, 2016

JessaWitzel commented Dec 1, 2016

chadwhitacre commented Dec 1, 2016

JessaWitzel commented Dec 1, 2016

mattbk commented Dec 2, 2016

JessaWitzel commented Dec 2, 2016

JessaWitzel commented Dec 2, 2016

mattbk commented Dec 2, 2016

chadwhitacre Dec 2, 2016

JessaWitzel Dec 2, 2016

chadwhitacre Dec 2, 2016

chadwhitacre Dec 2, 2016

chadwhitacre Dec 2, 2016

chadwhitacre commented Dec 2, 2016

chadwhitacre Dec 5, 2016

JessaWitzel Dec 5, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

Remove the To-do URL #4214

Remove the To-do URL #4214

Conversation

chadwhitacre commented Nov 30, 2016 • edited by JessaWitzel

Todo

chadwhitacre commented Nov 30, 2016 • edited by JessaWitzel

JessaWitzel commented Nov 30, 2016

chadwhitacre commented Nov 30, 2016 • edited

mattbk commented Nov 30, 2016 • edited

JessaWitzel commented Nov 30, 2016

JessaWitzel commented Dec 1, 2016

JessaWitzel commented Dec 1, 2016

chadwhitacre commented Dec 1, 2016

JessaWitzel commented Dec 1, 2016

mattbk commented Dec 2, 2016

JessaWitzel commented Dec 2, 2016

JessaWitzel commented Dec 2, 2016

mattbk commented Dec 2, 2016

chadwhitacre Dec 2, 2016

Choose a reason for hiding this comment

JessaWitzel Dec 2, 2016

Choose a reason for hiding this comment

chadwhitacre Dec 2, 2016

Choose a reason for hiding this comment

chadwhitacre Dec 2, 2016

Choose a reason for hiding this comment

chadwhitacre Dec 2, 2016

Choose a reason for hiding this comment

chadwhitacre commented Dec 2, 2016

chadwhitacre Dec 5, 2016

Choose a reason for hiding this comment

JessaWitzel Dec 5, 2016

Choose a reason for hiding this comment

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Dec 7, 2016

chadwhitacre commented Nov 30, 2016 •

edited by JessaWitzel

chadwhitacre commented Nov 30, 2016 •

edited by JessaWitzel

chadwhitacre commented Nov 30, 2016 •

edited

mattbk commented Nov 30, 2016 •

edited