Planet 5484 create zip on tag #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inwerpsel
force-pushed
the
planet-5484-create-zip-on-tag
branch
3 times, most recently
from
3cea92a
to
d7cb601
Compare
comzeradd
reviewed
Sep 22, 2020
comzeradd
reviewed
Sep 22, 2020
Inwerpsel
force-pushed
the
planet-5484-create-zip-on-tag
branch
from
39347ec
to
85496fd
Compare
comzeradd
reviewed
Sep 23, 2020
Inwerpsel
force-pushed
the
planet-5484-create-zip-on-tag
branch
from
00587d1
to
0c2c2da
Compare
Inwerpsel
added a commit
to greenpeace/planet4-plugin-gutenberg-blocks
that referenced
this pull request
Sep 23, 2020
* Same changes as were applied for master theme here greenpeace/planet4-master-theme#1182
Inwerpsel
added a commit
to greenpeace/planet4-plugin-gutenberg-blocks
that referenced
this pull request
Sep 23, 2020
* Same changes as were applied for master theme here greenpeace/planet4-master-theme#1182
Inwerpsel
force-pushed
the
planet-5484-create-zip-on-tag
branch
2 times, most recently
from
114b078
to
5af0cb2
Compare
|
Looks like updating the lock file was breaking our php tests. This seems to be the lock file of an older install. Shouldn't be an issue as the lock file is only used in our CI for this repo. |
Inwerpsel
commented
Sep 30, 2020
| - run: npm run build | ||
| - run: | ||
| name: "Remove files we don't want in the zip file." | ||
| command: rm -rf .circleci .git .githooks assets/src bin tests |
There was a problem hiding this comment.
I included the ones of which I was sure they wouldn't be needed in the zip. Maybe there's some others which would make sense to exclude here? The total zip size is currently about 1.8MB.
Inwerpsel
added a commit
to greenpeace/planet4-plugin-gutenberg-blocks
that referenced
this pull request
Sep 30, 2020
* Same changes as were applied for master theme here greenpeace/planet4-master-theme#1182
Inwerpsel
force-pushed
the
planet-5484-create-zip-on-tag
branch
2 times, most recently
from
43c26a8
to
ba92fc4
Compare
Inwerpsel
added a commit
to greenpeace/planet4-plugin-gutenberg-blocks
that referenced
this pull request
Sep 30, 2020
* Same changes as were applied for master theme here greenpeace/planet4-master-theme#1182
PLANET-5484 Get corresponding upload url for tag PLANET-5484 Exclude node_modules instead of remove (faster) PLANET-5484 Get upload url in same step * Right, CircleCI environment is local to a step, so the previous attempt of assigning in different steps couldn't work. Instead get the value in the same step, and use literal file name. PLANET-5484 Cat upload_url to tmp file instead PLANET-5484 Use dedicated token * The existing token didn't work to upload packages. PLANET-5484 jq format curl resopnse PLANET-5484 Try if slim image with fetch is faster PLANET-5484 Req composer installer dep PLANET-5484 add missing file extension PLANET-5484 Try skip puppeteer and chromium env vars PLANET-5484 Use fork from our org instead PLANET-5484 Also add python * `npm ci` gives some errors for python not being present, even though it continues to complete successfully. Still it causes the command to take a bit longer while it's looking for python. PLANET-5484 Also add make PLANET-5484 Add openssh and g++ too PLANET-5484 Run apk add before checkout step PLANET-5484 Add openssh-client PLANET-5484 make curl fail job, name commands PLANET-5484 Add step descriptions PLANET-5484 Sanity check on zip file size
Inwerpsel
force-pushed
the
planet-5484-create-zip-on-tag
branch
from
ba92fc4
to
053f272
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://jira.greenpeace.org/browse/PLANET-5484