Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "--no-index" option #607

Merged
merged 1 commit into from Oct 12, 2021
Merged

Conversation

filipemarins
Copy link
Contributor

Summary

Add --no-index option that allows disabling the index file generation.
This PR solves this issue.

Test plan

Screen Shot 2021-10-11 at 07 33 48

@vercel
Copy link

vercel bot commented Oct 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gregberge/svgr/GLT5VJkC6vaXLZcGf46UCPfxB6VY
✅ Preview: https://svgr-git-fork-filipemarins-disable-index-gregberge.vercel.app

@reintroducing
Copy link

@gregberge FYI this option in the API override does not seem to work, I had to add it to the CLI command I am running to disable the generation. I tried index: true and index: false and it had no impact and an index was still being generated. And also, the reason why I tried both is because its not immediately easy to figure out, due to the wording and the name of the option, to know which actually turns it off. I'd suggest renaming the API override to noIndex as well so that you know setting it to true disables index generation. index: true implies an index WILL be created.

@gregberge
Copy link
Owner

Hello @reintroducing you are right, I created an issue about it: #736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants