Formatted code; Added goimports to Makefile, Renamed pb_testproto to testpb. #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testpb. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
…testpb. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Codecov Report
@@ Coverage Diff @@
## v2 #291 +/- ##
==========================================
- Coverage 84.01% 83.58% -0.43%
==========================================
Files 30 30
Lines 932 932
==========================================
- Hits 783 779 -4
- Misses 110 114 +4
Partials 39 39
Continue to review full report at Codecov.
|
|
Should be good for review @johanbrandhorst (: Thanks! |
interceptors/client_test.go
Outdated
| @@ -12,7 +12,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/grpc-ecosystem/go-grpc-middleware/grpctesting" | |||
| pb_testproto "github.com/grpc-ecosystem/go-grpc-middleware/grpctesting/testproto" | |||
| testpb "github.com/grpc-ecosystem/go-grpc-middleware/grpctesting/testpb" | |||
There was a problem hiding this comment.
This should be /v2 somewhere right?
|
Easy to mess this so true |
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
|
Addresed all (: |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com