Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Go 1.9 / AppEngine support; assume go1.12 build tag #3767

Merged
merged 5 commits into from Jul 30, 2020
Merged

Remove Go 1.9 / AppEngine support; assume go1.12 build tag #3767

merged 5 commits into from Jul 30, 2020

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jul 29, 2020

No description provided.

@dfawley dfawley added the Type: Dependencies Updating/adding/removing dependencies label Jul 29, 2020
@dfawley dfawley added this to the 1.32 Release milestone Jul 29, 2020
@dfawley dfawley requested a review from menghanl July 29, 2020 00:31
menghanl
menghanl suggested changes Jul 29, 2020
View reviewed changes
internal/credentials/go110.go
@@ -1,5 +1,3 @@
// +build go1.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this file?
Or delete?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed.

security/advancedtls/sni_110.go
@@ -1,5 +1,3 @@
// +build go1.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dfawley dfawley closed this Jul 30, 2020
@dfawley dfawley reopened this Jul 30, 2020
@dfawley
Copy link
Member Author

dfawley commented Jul 30, 2020

cc @ZhenLian and @yihuazhang as FYI

@dfawley dfawley added Type: Dependencies Updating/adding/removing dependencies and removed Type: Dependencies Updating/adding/removing dependencies labels Jul 30, 2020
@dfawley dfawley merged commit bc714cd into grpc:master Jul 30, 2020
@dfawley dfawley deleted the go19 branch July 30, 2020 23:15
This was referenced Jul 31, 2020
Merged
Merged
Merged
Merged
@amaraliou amaraliou mentioned this pull request Aug 3, 2020
Closed
easwars added a commit to easwars/grpc-go that referenced this pull request Aug 4, 2020
@easwars
Add some appengine build constraints.
00d7f4b 
Support for Go1.9 and appengine was removed in
grpc#3767. But it looks like we still
need some way to do things differently for certain appengine builds.
@easwars easwars mentioned this pull request Aug 4, 2020
Merged
easwars added a commit that referenced this pull request Aug 5, 2020
@easwars
Add some appengine build constraints. (#3787)
5f7b337 
Support for Go1.9 and appengine was removed in #3767. But it looks like we still need some way to do things differently for certain appengine builds.
menghanl added a commit to menghanl/grpc-go that referenced this pull request Aug 27, 2020
@menghanl
[revert_gae] Revert "Remove Go 1.9 / AppEngine support; assume go1.12…
dee7804 
… build tag (grpc#3767)"

This reverts commit bc714cd.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@menghanl menghanl

Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Milestone
1.32 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dfawley @menghanl