netty: fix a race for channelz at server transport creation (backport v1.27.x) #6626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a chery-pick of b8474d6
A race condition was reported by user in #6601:
ServerImpl.start()
callsNettyServer.start()
while holdingServerImpl.lock
.NettyServer.start()
awaits a submitted runnable in eventloop. However, this pending runnable may never be executed because the eventloop might be executing some other task, likeServerListenerImpl.transportCreated()
, that is trying to acquireServerImpl.lock
causing a deadlock.This PR resolves the particular issue reported in #6601 for server with a single port, but
NettyServer
(https://github.com/grpc/grpc-java/blob/v1.26.0/netty/src/main/java/io/grpc/netty/NettyServer.java#L251) andServerImpl
(https://github.com/grpc/grpc-java/blob/v1.26.0/core/src/main/java/io/grpc/internal/ServerImpl.java#L184) in general still have the same potential risk of deadlock, which need further fix.