Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netty: fix a race for channelz at server transport creation (backport v1.27.x) #6626

Merged
merged 1 commit into from Jan 22, 2020
Merged

netty: fix a race for channelz at server transport creation (backport v1.27.x) #6626

merged 1 commit into from Jan 22, 2020

Commits on Jan 22, 2020

  1. netty: fix a race for channelz at server transport creation 

    A race condition was reported by user in grpc#6601:

`ServerImpl.start()` calls `NettyServer.start()` while holding `ServerImpl.lock`. `NettyServer.start()` awaits a submitted runnable in eventloop. However, this pending runnable may never be executed because the eventloop might be executing some other task, like `ServerListenerImpl.transportCreated()`, that is trying to acquire `ServerImpl.lock` causing a deadlock.

This PR resolves the particular issue reported in grpc#6601 for server with a single port, but `NettyServer` (https://github.com/grpc/grpc-java/blob/v1.26.0/netty/src/main/java/io/grpc/netty/NettyServer.java#L251) and `ServerImpl` (https://github.com/grpc/grpc-java/blob/v1.26.0/core/src/main/java/io/grpc/internal/ServerImpl.java#L184) in general still have the same potential risk of deadlock, which need further fix.
    @dapengzhang0
    dapengzhang0 committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    a3af83b View commit details
    Browse the repository at this point in the history