Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: Use wrr_locality LB and support load_balancing_policy in Cluster #9141

Merged
merged 6 commits into from May 6, 2022
Merged

xds: Use wrr_locality LB and support load_balancing_policy in Cluster #9141

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
75d3e43
Use new wrr_locality LB policy.
temawi Apr 28, 2022
8a02214
xds: Use load_balancing_policy if provided in Cluster.
temawi May 3, 2022
84bc3da
Better localityWeights handling.
temawi May 6, 2022
735956d
Review feedback.
temawi May 6, 2022
54b007e
Fail the whole conversion process on the first conversion failure.
temawi May 6, 2022
fbfb33e
Remove unnecessary casts.
temawi May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions xds/src/main/java/io/grpc/xds/ClientXdsClient.java
View file
Open in desktop
Expand Up @@ -1635,9 +1635,7 @@ static CdsUpdate processCluster(Cluster cluster, Set<String> retainedEdsResource
}
CdsUpdate.Builder updateBuilder = structOrError.getStruct();

// TODO: If load_balancing_policy is set in Cluster use it for LB config, otherwise fall back
// to using the legacy lb_policy field.
ImmutableMap<String, ?> lbPolicyConfig = LegacyLoadBalancerConfigFactory.newConfig(cluster,
ImmutableMap<String, ?> lbPolicyConfig = LoadBalancerConfigFactory.newConfig(cluster,
enableLeastRequest);

// Validate the LB config by trying to parse it with the corresponding LB provider.
Expand Down
115 changes: 0 additions & 115 deletions xds/src/main/java/io/grpc/xds/LegacyLoadBalancerConfigFactory.java
View file
Open in desktop

This file was deleted.