Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synapse module for terratest #1303

Merged
merged 10 commits into from
Jun 20, 2023

Conversation

sweanan
Copy link

@sweanan sweanan commented Jun 8, 2023

Description

Implements basic example for the Azure Syanspe Module

Fixes #1302 .

@sweanan
Copy link
Author

sweanan commented Jun 8, 2023

@HadwaAbdelhalem, @robcamer - JFYI

default = "sqladminuser"
}

variable "sy_sqlpool_sku_name" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update name to avoid obberviations for both variables sy_sqlpool_sku_name, and sy_sqlpool_create_mode

Suggested change
variable "sy_sqlpool_sku_name" {
variable "synapse_sqlpool_sku_name"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HadwaAbdelhalem updated

default = "Standard"
}

variable "storage_replication_type" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
variable "storage_replication_type" {
variable "storage_account_replication_type"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HadwaAbdelhalem updated


// Create a synapse client
synapseWorkspaceClient := synapse.NewWorkspacesClientWithBaseURI(baseURI, subscriptionID)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra comment ynapse.SQLPoolsClient

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HadwaAbdelhalem cleaned up

)

// GetSynapseWorkspaceClientE is a helper function that will setup a mysql server client.
func GetSynapseWorkspaceClientE(subscriptionID string) (*synapse.WorkspacesClient, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetSynapseWorkspaceClientE this helper does not seem to be used anywhere! can you clean it up

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HadwaAbdelhalem cleaned up

@denis256
Copy link
Member

[INFO] Initializing environment for https://github.com/gruntwork-io/pre-commit.
goimports................................................................Passed
Terraform fmt............................................................Failed
- hook id: terraform-fmt
- files were modified by this hook

main.tf
outputs.tf

@sweanan
Copy link
Author

sweanan commented Jun 12, 2023

[INFO] Initializing environment for https://github.com/gruntwork-io/pre-commit.
goimports................................................................Passed
Terraform fmt............................................................Failed
- hook id: terraform-fmt
- files were modified by this hook

main.tf
outputs.tf

Thank you, fixed

@sweanan
Copy link
Author

sweanan commented Jun 12, 2023

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/sweanan/terratest/actions/runs/5247611530

1 similar comment
@sweanan
Copy link
Author

sweanan commented Jun 12, 2023

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/sweanan/terratest/actions/runs/5247611530

@sweanan
Copy link
Author

sweanan commented Jun 12, 2023

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/sweanan/terratest/actions/runs/5247611530

@sweanan
Copy link
Author

sweanan commented Jun 12, 2023

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/sweanan/terratest/actions/runs/5248471303

@sweanan
Copy link
Author

sweanan commented Jun 13, 2023

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/sweanan/terratest/actions/runs/5254423377

@sweanan
Copy link
Author

sweanan commented Jun 13, 2023

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/sweanan/terratest/actions/runs/5254494406

Copy link
Contributor

@HadwaAbdelhalem HadwaAbdelhalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, LGTM!

@denis256 denis256 merged commit e54e4f0 into gruntwork-io:master Jun 20, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for Azure Synapse Analytics terratest module
3 participants