-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
synapse module for terratest #1303
synapse module for terratest #1303
Conversation
@HadwaAbdelhalem, @robcamer - JFYI |
default = "sqladminuser" | ||
} | ||
|
||
variable "sy_sqlpool_sku_name" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update name to avoid obberviations for both variables sy_sqlpool_sku_name, and sy_sqlpool_create_mode
variable "sy_sqlpool_sku_name" { | |
variable "synapse_sqlpool_sku_name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HadwaAbdelhalem updated
default = "Standard" | ||
} | ||
|
||
variable "storage_replication_type" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable "storage_replication_type" { | |
variable "storage_account_replication_type" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HadwaAbdelhalem updated
|
||
// Create a synapse client | ||
synapseWorkspaceClient := synapse.NewWorkspacesClientWithBaseURI(baseURI, subscriptionID) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra comment ynapse.SQLPoolsClient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HadwaAbdelhalem cleaned up
modules/azure/synapse.go
Outdated
) | ||
|
||
// GetSynapseWorkspaceClientE is a helper function that will setup a mysql server client. | ||
func GetSynapseWorkspaceClientE(subscriptionID string) (*synapse.WorkspacesClient, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetSynapseWorkspaceClientE this helper does not seem to be used anywhere! can you clean it up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HadwaAbdelhalem cleaned up
|
Thank you, fixed |
[Microsoft CI Bot] TL;DR; failure 🤦 You can check the status of the CI Pipeline logs here ; https://github.com/sweanan/terratest/actions/runs/5247611530 |
1 similar comment
[Microsoft CI Bot] TL;DR; failure 🤦 You can check the status of the CI Pipeline logs here ; https://github.com/sweanan/terratest/actions/runs/5247611530 |
[Microsoft CI Bot] TL;DR; failure 🤦 You can check the status of the CI Pipeline logs here ; https://github.com/sweanan/terratest/actions/runs/5247611530 |
[Microsoft CI Bot] TL;DR; failure 🤦 You can check the status of the CI Pipeline logs here ; https://github.com/sweanan/terratest/actions/runs/5248471303 |
[Microsoft CI Bot] TL;DR; failure 🤦 You can check the status of the CI Pipeline logs here ; https://github.com/sweanan/terratest/actions/runs/5254423377 |
[Microsoft CI Bot] TL;DR; failure 🤦 You can check the status of the CI Pipeline logs here ; https://github.com/sweanan/terratest/actions/runs/5254494406 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, LGTM!
Description
Implements basic example for the Azure Syanspe Module
Fixes #1302 .