Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move storybook configs and deps to configs/storybook #1461

Merged
merged 8 commits into from
May 21, 2024
Merged

Move storybook configs and deps to configs/storybook #1461

merged 8 commits into from
May 21, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented May 17, 2024 •
edited

What are you changing?

Moving storybook configs and deps to configs/storybook

Why?

To keep the root clean and match the rollup setup.

@sndrs sndrs requested review from a team as code owners May 17, 2024 09:53
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 17, 2024 •
edited

⚠️ No Changeset found

Latest commit: 4a584c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label May 17, 2024
@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label May 17, 2024
@sndrs sndrs force-pushed the sndrs/storybook-configs branch 2 times, most recently from 2e11199 to cf17677 Compare May 17, 2024 09:59
@sndrs sndrs mentioned this pull request May 17, 2024
Merged
oliverabrahams
oliverabrahams approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sndrs sndrs marked this pull request as draft May 17, 2024 11:18
@sndrs
Copy link
Member Author

sndrs commented May 17, 2024

Looks good

finding issues...

@oliverabrahams oliverabrahams self-requested a review May 20, 2024 08:18
@sndrs sndrs changed the base branch from main to sndrs/tsconfig-ignore May 20, 2024 16:39
@sndrs sndrs marked this pull request as ready for review May 20, 2024 16:39
@sndrs
Copy link
Member Author

sndrs commented May 20, 2024

finding issues...

fixed them 🕺

Base automatically changed from sndrs/tsconfig-ignore to main May 21, 2024 14:07
@jamesmockett jamesmockett requested a review from a team as a code owner May 21, 2024 14:07
@jamesmockett jamesmockett requested review from a team as code owners May 21, 2024 14:07
@sndrs sndrs enabled auto-merge (squash) May 21, 2024 14:10
@sndrs sndrs merged commit 1761f99 into main May 21, 2024
20 checks passed
@sndrs sndrs deleted the sndrs/storybook-configs branch May 21, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverabrahams oliverabrahams Awaiting requested review from oliverabrahams

Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sndrs @oliverabrahams