Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically fetch control epic copy #9

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Dynamically fetch control epic copy #9

merged 1 commit into from
Jan 22, 2020

Commits on Jan 22, 2020

  1. Fetch default epic copy dynamically 

    Fetch the copy for the default epic from an API endpoint once when we
boot the app. At this point we're still missing the following, which
we'll follow up on in future PRs:

* Elegant handling/retrying if we fail to fetch the content

* We don't have full support for all possible placeholders yet (I think
the full list is %%CURRENCY_SYMBOL%%, %%COUNTRY_NAME%% and
%%ARTICLE_COUNT%%)

* We do support interpolating the currency symbol, but we just use a
hardcoded value. In future we'll want to bring across the logic from
frontend where we resolve this based on the geolocation.
    @tjmw
    tjmw committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    0c34a4b View commit details
    Browse the repository at this point in the history