-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically fetch control epic copy #9
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
import { fetchDefaultEpicContent } from './contributionsApi'; | ||
|
||
jest.mock('node-fetch', () => require('fetch-mock').sandbox()); | ||
// eslint-disable-next-line @typescript-eslint/no-var-requires | ||
const fetchMock = require('node-fetch'); | ||
|
||
describe('fetchDefaultEpic', () => { | ||
it('fetches and returns the data in the expected format', async () => { | ||
const url = | ||
'https://interactive.guim.co.uk/docsdata/1fy0JolB1bf1IEFLHGHfUYWx-niad7vR9K954OpTOvjE.json'; | ||
|
||
const response = { | ||
sheets: { | ||
control: [ | ||
{ | ||
heading: 'Since you’re here...', | ||
paragraphs: 'First paragraph', | ||
highlightedText: 'Highlighted Text', | ||
}, | ||
{ | ||
heading: '', | ||
paragraphs: 'Second paragraph', | ||
highlightedText: '', | ||
}, | ||
], | ||
}, | ||
}; | ||
|
||
fetchMock.get(url, response); | ||
|
||
const epicData = await fetchDefaultEpicContent(); | ||
|
||
expect(epicData).toEqual({ | ||
heading: 'Since you’re here...', | ||
paragraphs: ['First paragraph', 'Second paragraph'], | ||
highlighted: ['Highlighted Text'], | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import fetch from 'node-fetch'; | ||
|
||
const defaultEpicUrl = | ||
'https://interactive.guim.co.uk/docsdata/1fy0JolB1bf1IEFLHGHfUYWx-niad7vR9K954OpTOvjE.json'; | ||
|
||
export type DefaultEpicContent = { | ||
heading?: string; | ||
paragraphs: string[]; | ||
highlighted: string[]; | ||
}; | ||
|
||
export const fetchDefaultEpicContent = async (): Promise<DefaultEpicContent> => { | ||
const response = await fetch(defaultEpicUrl); | ||
if (!response.ok) { | ||
throw new Error( | ||
`Encountered a non-ok response when fetching default epic: ${response.status}`, | ||
); | ||
} | ||
const data = await response.json(); | ||
const control = data?.sheets?.control; | ||
|
||
return control.reduce( | ||
( | ||
acc: DefaultEpicContent, | ||
item: { heading: string; paragraphs: string; highlightedText: string }, | ||
) => { | ||
if (!acc.heading && item.heading) acc.heading = item.heading; | ||
if (item.paragraphs) acc.paragraphs.push(item.paragraphs); | ||
if (item.highlightedText) acc.highlighted.push(item.highlightedText); | ||
return acc; | ||
}, | ||
{ paragraphs: [], highlighted: [] }, | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the thinking behind not using top-level await in the end:? (Just curious really.) I've seen suggestions that it makes modules a bit harder to reason about/can be surprising, but on the flip-side for the key start file this might not matter and it might help remove the bootApp wrapping and indentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! It was a combination of things. When I looked it up I was reminded that, as you mentioned here, there is some push-back on whether or not top level await makes sense. I don't think any of the arguments against it affect us right now, but felt like maybe it was setting a precedent and it could be easy to avoid us having the conversation in future.
The other (somewhat major 😸) reason is that it's not supported in TypeScript yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha okay, that last argument is pretty slam-dunk :).
It looks like they're adding it in the next version - https://devblogs.microsoft.com/typescript/announcing-typescript-3-8-beta/#top-level-await