Add HCB Phone Number #1101
Merged
Add HCB Phone Number #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naga Chaitanya Varma <69190057+Chay2203@users.noreply.github.com>
|
@Chay2203 is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
|
Sure @sampoder will check that. |
garyhtou
requested changes
Mar 7, 2024
components/footer.js
Outdated
| @@ -179,7 +179,7 @@ const Footer = ({ | |||
| <Service href={`mailto:${email}`} icon="email-fill" /> | |||
| </Grid> | |||
| <Text my={2}> | |||
| <Link href="tel:1-855-625-HACK">1-855-625-HACK</Link> | |||
| <Link href="tel:+1 (844) 237 2290">+1 (844) 237 2290</Link> | |||
There was a problem hiding this comment.
Great! In addition to @sampoder's feedback, can we also change the phone number in the href to use hyphens as the separator?
This is because the spec says tel URIs should not contain spaces.
The inner content of the link can stay the same!
Suggested change
| <Link href="tel:+1 (844) 237 2290">+1 (844) 237 2290</Link> | |
| <Link href="tel:+1-844-237-2290">+1 (844) 237 2290</Link> |
Signed-off-by: Naga Chaitanya Varma <69190057+Chay2203@users.noreply.github.com>
Signed-off-by: Naga Chaitanya Varma <69190057+Chay2203@users.noreply.github.com>
garyhtou
reviewed
Mar 14, 2024
Signed-off-by: Naga Chaitanya Varma <69190057+Chay2203@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tobyab
pushed a commit
that referenced
this pull request
Mar 16, 2024
Co-authored-by: Gary Tou <gary@garytou.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue #1099.
Description:
I have updated the Phone Number in the footer section of all HCB Pages.
Please review the changes.